Stop accessing None as a dictionary #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyMapping_HasKeyString does not work on None
Accidentally, it used to return false result on silent errors.
Since Python 3.13, this is what happens instead:
>>> import pylibmc
>>> m = pylibmc.Client(["10.0.0.1"], binary=True)
Exception ignored in PyMapping_HasKeyString(); consider using PyMapping_HasKeyStringWithError(), PyMapping_GetOptionalItemString() or PyMapping_GetItemString():
Traceback (most recent call last):
File "/usr/lib64/python3.13/site-packages/pylibmc/client.py", line 142, in __init__
super().__init__(servers=translate_server_specs(servers),
TypeError: 'NoneType' object is not subscriptable
...
Exception ignored in PyMapping_HasKeyString(); consider using PyMapping_HasKeyStringWithError(), PyMapping_GetOptionalItemString() or PyMapping_GetItemString():
Traceback (most recent call last):
File "/usr/lib64/python3.13/site-packages/pylibmc/client.py", line 142, in __init__
super().__init__(servers=translate_server_specs(servers),
TypeError: 'NoneType' object is not subscriptable
When this is run via pytest, it leads to:
pytest.PytestUnraisableExceptionWarning: Exception ignored in PyMapping_HasKeyString(); consider using PyMapping_HasKeyStringWithError(), PyMapping_GetOptionalItemString() or PyMapping_GetItemString(): None
Fixes pallets-eco/cachelib#400
|
Can this please be merged? |
|
I'd appreciate a quick merge on this as well. Since upgrading to p3.13, these messages are severely clogging up our logs. |
|
Is there any reason this cannot be merged? |
|
I think the main reason this cannot be merged is just that nobody is maintaining this repo anymore. |
|
You can complain about my attendance to this project when you pay my rent, @lachesis. |
|
Thanks, we should probably have a test for this, but 🤷 |
|
No complaint, just telling it how I see it. I've got my own share of unmaintained projects! Appreciate the review and merge. Now I can drop my fork and go back to using the mainline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMapping_HasKeyString does not work on None
Accidentally, it used to return false result on silent errors.
Since Python 3.13, this is what happens instead:
When this is run via pytest, it leads to:
Fixes pallets-eco/cachelib#400