Skip to content

Commit 8f55521

Browse files
tphoneyactions-user
authored andcommitted
chore, move changetimeline labels to sdp-go (#1331)
this is so we dont have to export api-server for the public cli repository GitOrigin-RevId: ff1dd615034471358cee1816b2c4e2334e51d264
1 parent 162569d commit 8f55521

File tree

3 files changed

+22
-6
lines changed

3 files changed

+22
-6
lines changed

cmd/changes_get_change.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
"github.com/hexops/gotextdiff"
1616
"github.com/hexops/gotextdiff/myers"
1717
diffspan "github.com/hexops/gotextdiff/span"
18-
"github.com/overmindtech/workspace/api-server/server/changetimeline"
1918
"github.com/overmindtech/cli/sdp-go"
2019
log "github.com/sirupsen/logrus"
2120
"github.com/spf13/cobra"
@@ -102,7 +101,7 @@ fetch:
102101
}
103102
timeLine = rawTimeLine.Msg
104103
for _, entry := range timeLine.GetEntries() {
105-
if entry.GetName() == string(changetimeline.ChangeTimelineEntryV2NameAutoTagging) && entry.GetStatus() == sdp.ChangeTimelineEntryStatus_DONE {
104+
if entry.GetName() == string(sdp.ChangeTimelineEntryV2NameAutoTagging) && entry.GetStatus() == sdp.ChangeTimelineEntryStatus_DONE {
106105
break fetch
107106
}
108107
}
@@ -155,7 +154,7 @@ fetch:
155154

156155
var calculateRiskStep *sdp.ChangeTimelineEntryV2
157156
for _, entry := range timeLine.GetEntries() {
158-
if entry.GetName() == string(changetimeline.ChangeTimelineEntryV2NameCalculatedRisks) {
157+
if entry.GetName() == string(sdp.ChangeTimelineEntryV2NameCalculatedRisks) {
159158
calculateRiskStep = entry
160159
break
161160
}

cmd/terraform_plan.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
"github.com/google/uuid"
1717
"github.com/muesli/reflow/wordwrap"
1818
"github.com/overmindtech/pterm"
19-
"github.com/overmindtech/workspace/api-server/server/changetimeline"
2019
"github.com/overmindtech/cli/tfutils"
2120
"github.com/overmindtech/cli/sdp-go"
2221
log "github.com/sirupsen/logrus"
@@ -364,7 +363,7 @@ retryLoop:
364363
}
365364

366365
// check if change analysis is done
367-
if entry.GetName() == string(changetimeline.ChangeTimelineEntryV2NameAutoTagging) && entry.GetStatus() == sdp.ChangeTimelineEntryStatus_DONE {
366+
if entry.GetName() == string(sdp.ChangeTimelineEntryV2NameAutoTagging) && entry.GetStatus() == sdp.ChangeTimelineEntryStatus_DONE {
368367
changeAnalysisSpinner.Success()
369368
break retryLoop
370369
}
@@ -374,7 +373,7 @@ retryLoop:
374373
}
375374
var calculateRiskStep *sdp.ChangeTimelineEntryV2
376375
for _, entry := range timeLine.GetEntries() {
377-
if entry.GetName() == string(changetimeline.ChangeTimelineEntryV2NameCalculatedRisks) {
376+
if entry.GetName() == string(sdp.ChangeTimelineEntryV2NameCalculatedRisks) {
378377
calculateRiskStep = entry
379378
break
380379
}

sdp-go/changetimeline.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package sdp
2+
3+
type ChangeTimelineEntryV2Name string
4+
5+
// If you add/delete/move an entry here, make sure to update/check the following:
6+
// - the PopulateChangeTimelineV2 function
7+
// - GetChangeTimelineV2 in api-server/server/changesservice.go
8+
// - resetChangeAnalysisTables in api-server/server/changeanalysis/shared.go
9+
// - the cli tool if we are waiting for a change analysis to finish
10+
const (
11+
ChangeTimelineEntryV2NameChangeCreated ChangeTimelineEntryV2Name = "Change Created"
12+
ChangeTimelineEntryV2NameMappedResources ChangeTimelineEntryV2Name = "Mapped Resources"
13+
ChangeTimelineEntryV2NameCalculatedBlastRadius ChangeTimelineEntryV2Name = "Calculated Blast Radius"
14+
ChangeTimelineEntryV2NameCalculatedRisks ChangeTimelineEntryV2Name = "Calculated Risks"
15+
ChangeTimelineEntryV2NameAutoTagging ChangeTimelineEntryV2Name = "Auto Tagging"
16+
ChangeTimelineEntryV2NameChangeStarted ChangeTimelineEntryV2Name = "Change Started"
17+
ChangeTimelineEntryV2NameChangeFinished ChangeTimelineEntryV2Name = "Change Finished"
18+
)

0 commit comments

Comments
 (0)