Merge pull request #9 from alafon/key-functions-not-private

mcg-web · web-flow · commit 11c2f809e67d · 2017-01-24T16:52:11.000+01:00
Make it possible to call key functions when extending Dataloader
diff --git a/src/DataLoader.php b/src/DataLoader.php
@@ -270,15 +270,24 @@ private static function awaitInstances()
         }
     }
 
-    private function getCacheKeyFromKey($key)
+    /**
+     * @param $key
+     *
+     * @return mixed
+     */
+    protected function getCacheKeyFromKey($key)
     {
         $cacheKeyFn = $this->options->getCacheKeyFn();
         $cacheKey = $cacheKeyFn ? $cacheKeyFn($key) : $key;
 
         return $cacheKey;
     }
 
-    private function checkKey($key, $method)
+    /**
+     * @param $key
+     * @param $method
+     */
+    protected function checkKey($key, $method)
     {
         if (null === $key) {
             throw new \InvalidArgumentException(

Original file line number	Diff line number	Diff line change
`@@ -270,15 +270,24 @@ private static function awaitInstances()`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`
`273`		`- private function getCacheKeyFromKey($key)`
	`273`	`+ /**`
	`274`	`+ * @param $key`
	`275`	`+ *`
	`276`	`+ * @return mixed`
	`277`	`+ */`
	`278`	`+ protected function getCacheKeyFromKey($key)`
`274`	`279`	`{`
`275`	`280`	`$cacheKeyFn = $this->options->getCacheKeyFn();`
`276`	`281`	`$cacheKey = $cacheKeyFn ? $cacheKeyFn($key) : $key;`
`277`	`282`
`278`	`283`	`return $cacheKey;`
`279`	`284`	`}`
`280`	`285`
`281`		`- private function checkKey($key, $method)`
	`286`	`+ /**`
	`287`	`+ * @param $key`
	`288`	`+ * @param $method`
	`289`	`+ */`
	`290`	`+ protected function checkKey($key, $method)`
`282`	`291`	`{`
`283`	`292`	`if (null === $key) {`
`284`	`293`	`throw new \InvalidArgumentException(`