Overwrite external config options in pom.xml

[tofi86]

It would be great to have the following available in your plugin:

<configuration>
	<infile>${project.basedir}/src/build/launch4j-config.xml</infile>
	
	<versionInfo>
		<fileVersion>${my.version.number}.${my.build.number}</fileVersion>
		<txtFileVersion>${my.version.number}</txtFileVersion>
		<productVersion>${my.version.number}.${my.build.number}</productVersion>
		<txtProductVersion>${my.version.number}</txtProductVersion>
	</versionInfo>
</configuration>

so to be able to use an external config file but override several configuration options like version numbers, which are naturally handled within maven.

With the launch4j ant task, this is possible like this:

<launch4j
	jar="${out.dir}/my.jar"
	outfile="${out.dir}/my.exe"
	configFile="${build.dir}/launch4j/launch4j-config.xml"
	fileVersion="${program.version.number}"
	txtFileVersion="${program.version.txtNumber}"
	productVersion="${program.version.number}"
	txtProductVersion="${program.version.txtNumber}"
/>

Any chance to include this in a future version?

Thanks,
Tobias

[tofi86]

Also pinging @adamdec as he implemented the original <infile> support in PR #32.
Any ideas?

[adamdec]

Can you please prepare PR?

[tofi86]

Okay, I can give it a try. Seems easier than I thought—also the ANT task solves this a bit hacky: https://sourceforge.net/p/launch4j/git/ci/master/tree/src/net/sf/launch4j/ant/Launch4jTask.java#l83

[tofi86]

Created Pull Request #49 for this. Would love to see this integrated in the next version!

[myron0815]

Hej... does this work as expected (in maven)?
Having above configuration... but according to source, i can ONLY override jar/outfile/ and SOME named versioninfo, but not other values?! Why not all?!

Why not just load file in infile.exists(), skip the else and overwrite all with POM values?
(Or the other way round, new config = pom values, and only override from xml)

Got some NPE, b/c i didn't have the specified in xml (since i moved it to pom)

[lukaszlenart]

@myron0815 see discussion under #49