Skip to content

Commit 88ca668

Browse files
ichokshiichokshi
authored andcommitted
Changes in example
Merge branch 'okafka-23.4.0.0' of https://github.com/oracle/okafka.git into okafka-23.4.0.0
1 parent a219857 commit 88ca668

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

README.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ To run `OKafka application` against Oracle Database, a database user must be cre
2222

2323
```roomsql
2424
create user <user> identified by <password>
25-
GRANT CONNECT , RESOURCE to user;
25+
GRANT CONNECT , RESOURCE to user;
26+
GRANT UNLIMITED TABLESPACE to user;
2627
GRANT EXECUTE on DBMS_AQ to user;
2728
GRANT EXECUTE on DBMS_AQADM to user;
2829
GRANT EXECUTE on DBMS_AQIN to user;
@@ -36,6 +37,13 @@ GRANT SELECT on USER_QUEUE_PARTITION_ASSIGNMENT_TABLE to user;
3637
exec DBMS_AQADM.GRANT_PRIV_FOR_RM_PLAN('user');
3738
```
3839

40+
Note:
41+
It is preferred in general to assign or grant a specific quota on a tablespace to a database user instead of granting unlimited quota in default tablespace. One can create a table space and use the following command to grant quota on a specific tablespace to a database user.
42+
43+
```roomsql
44+
ALTER USER user QUOTA UNLIMITED /* or size-clause */ on tablespace_name;
45+
```
46+
3947
Once user is created and above privileges are granted, connect to Oracle Database as this user and create a Transactional Event Queue using below PL/SQL script. One can also use `KafkaAdmin` interface as shown in `CreateTopic.java` in `examples` directory to create a Transactional Event Queue.
4048

4149
```roomsql

clients/src/test/java/org/oracle/okafka/tests/OkafkaAutoOffsetReset.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,12 @@
44
import java.io.IOException;
55
import java.time.Duration;
66
import java.util.Arrays;
7-
import java.util.Collection;
8-
import java.util.HashMap;
9-
import java.util.Map;
107
import java.util.Properties;
118
import org.apache.kafka.clients.consumer.Consumer;
12-
import org.apache.kafka.clients.consumer.ConsumerRebalanceListener;
139
import org.apache.kafka.clients.consumer.ConsumerRecord;
1410
import org.apache.kafka.clients.consumer.ConsumerRecords;
15-
import org.apache.kafka.clients.consumer.OffsetAndMetadata;
16-
import org.apache.kafka.common.TopicPartition;
1711
import org.junit.Test;
1812
import org.oracle.okafka.clients.consumer.KafkaConsumer;
19-
import org.oracle.okafka.clients.consumer.internals.SubscriptionState;
2013

2114
public class OkafkaAutoOffsetReset {
2215

examples/consumer/src/main/java/org/oracle/okafka/examples/ConsumerOKafka.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@
1111
import java.time.Duration;
1212
import java.util.Arrays;
1313

14-
import org.apache.kafka.clients.consumer.KafkaConsumer;
14+
import org.apache.kafka.clients.consumer.Consumer;
1515
import org.apache.kafka.common.TopicPartition;
1616
import org.apache.kafka.clients.consumer.Consumer;
1717
import org.apache.kafka.clients.consumer.ConsumerRecords;
1818
import org.apache.kafka.clients.consumer.ConsumerRecord;
19+
import org.oracle.okafka.clients.consumer.KafkaConsumer;
1920

2021
public class ConsumerOKafka {
2122
public static void main(String[] args) {

0 commit comments

Comments
 (0)