allow empty allowed limits and provide the default limit in BaseConfig artprima#3

Author: Denis V

QueryFilter/Config/BaseConfig.php

@@ -13,6 +13,8 @@
  */
 class BaseConfig implements ConfigInterface
 {
+    private const DEFAULT_LIMIT = 10;
+
     /**
      * @var Request
      */
@@ -106,7 +108,7 @@ public function addSearchByAliases(Alias $alias): ConfigInterface
      */
     public function getSearchByAliases(): array
     {
-        return $this->searchBy['aliases'];
+        return $this->searchBy['aliases'] ?? [];
     }
 
     /**
@@ -177,7 +179,7 @@ public function getRepositoryCallback(): callable
      */
     public function getAllowedLimits(): array
     {
-        return $this->allowedLimits;
+        return $this->allowedLimits ?? [];
     }
 
     /**
@@ -205,7 +207,7 @@ public function setDefaultLimit(int $limit): ConfigInterface
      */
     public function getDefaultLimit(): int
     {
-        return $this->defaultLimit;
+        return $this->defaultLimit ?? self::DEFAULT_LIMIT;
     }
 
     /**

QueryFilter/Config/ConfigInterface.php

@@ -109,7 +109,7 @@ public function setAllowedLimits(array $allowedLimits): ConfigInterface;
      *
      * @return array
      */
-    public function getAllowedLimits(): array;
+    public function getAllowedLimits(): ?array;
 
     /**
      * @var int $limit default limit in case of limit not specified or limit is not within the allowed limits

QueryFilter/QueryFilter.php

@@ -226,7 +226,7 @@ private function getQueryFilterArgs(ConfigInterface $config): QueryFilterArgs
 
         $limit = $config->getRequest()->getLimit();
         $allowedLimits = $config->getAllowedLimits();
-        if ($limit === -1 || (!empty($allowedLimits) && !in_array($limit, $config->getAllowedLimits(), true))) {
+        if ($limit === -1 || !in_array($limit, $allowedLimits, true)) {
             $limit = $config->getDefaultLimit();
         }