From 2236724ef5f2a785ec9fc0d77e1902aaa394b61e Mon Sep 17 00:00:00 2001 From: Konstantinos Spartalis Date: Wed, 10 Sep 2025 02:22:27 +0300 Subject: [PATCH 1/4] Update LeCertificate.php --- .../mvc/app/library/OPNsense/AcmeClient/LeCertificate.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php index e45f92dedd..9c55d51342 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php @@ -47,6 +47,11 @@ class LeCertificate extends LeCommon { public const CONFIG_PATH = 'certificates.certificate'; + protected $cert_file; + protected $cert_key_file; + protected $cert_chain_file; + protected $cert_fullchain_file; + /* * Create the object by collecting and storing all required data * @param $uuid string the UUID of the configuration object From ec95af4b3a12396d854b7492a02ce62acfb9441f Mon Sep 17 00:00:00 2001 From: Konstantinos Spartalis Date: Mon, 15 Sep 2025 00:03:57 +0300 Subject: [PATCH 2/4] Update SettingsController.php --- .../controllers/OPNsense/AcmeClient/Api/SettingsController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php index 5251a32f7c..8a114978f3 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php @@ -77,7 +77,7 @@ public function fetchCronIntegrationAction() } else { // Cron job NOT found. This should not happen, try to fix // this automatically. - $this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: ${cron_uuid}"); + $this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: {$cron_uuid}"); // Search for existing AcmeClient cron job. foreach ((new Cron())->getNodeByReference('jobs.job')->iterateItems() as $cron) { From cf378d2ae6a9b2c20daf2131b79ade844125f09f Mon Sep 17 00:00:00 2001 From: Konstantinos Spartalis Date: Mon, 15 Sep 2025 00:03:57 +0300 Subject: [PATCH 3/4] Update SettingsController.php --- .../OPNsense/AcmeClient/Api/SettingsController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php index 5251a32f7c..4104f6bf29 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php @@ -77,7 +77,7 @@ public function fetchCronIntegrationAction() } else { // Cron job NOT found. This should not happen, try to fix // this automatically. - $this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: ${cron_uuid}"); + $this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: {$cron_uuid}"); // Search for existing AcmeClient cron job. foreach ((new Cron())->getNodeByReference('jobs.job')->iterateItems() as $cron) { @@ -86,7 +86,7 @@ public function fetchCronIntegrationAction() if ($_origin == 'AcmeClient') { // Found a matching AcmeClient cron job. $cron_found = 1; - $this->getLogger()->notice("AcmeClient: found existing AcmeClient cron job, fixing inconsistency in config (new UUID: ${_uuid})"); + $this->getLogger()->notice("AcmeClient: found existing AcmeClient cron job, fixing inconsistency in config (new UUID: {$_uuid})"); // Update UUID in Acme Client config. $mdlAcme->settings->UpdateCron = $_uuid; // Save updated configuration. From 93a485791b9cee8e90ff451e1628dd49f2ddca59 Mon Sep 17 00:00:00 2001 From: Konstantinos Spartalis Date: Wed, 19 Nov 2025 14:34:22 +0200 Subject: [PATCH 4/4] changelog --- security/acme-client/Makefile | 2 +- security/acme-client/pkg-descr | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/security/acme-client/Makefile b/security/acme-client/Makefile index a81e74fb70..d95e12b214 100644 --- a/security/acme-client/Makefile +++ b/security/acme-client/Makefile @@ -1,5 +1,5 @@ PLUGIN_NAME= acme-client -PLUGIN_VERSION= 4.10 +PLUGIN_VERSION= 4.10.1 PLUGIN_COMMENT= ACME Client PLUGIN_MAINTAINER= opnsense@moov.de PLUGIN_DEPENDS= acme.sh py${PLUGIN_PYTHON}-dns-lexicon diff --git a/security/acme-client/pkg-descr b/security/acme-client/pkg-descr index f954107257..0cba50c3f8 100644 --- a/security/acme-client/pkg-descr +++ b/security/acme-client/pkg-descr @@ -8,6 +8,11 @@ WWW: https://github.com/acmesh-official/acme.sh Plugin Changelog ================ +4.10.1 + +Fixed: +* syntax depreciation caused errors (#4938) + 4.10 Added: