Bump/primer upstream #226
Merged
Bump/primer upstream #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Behrokh Satarnejad <[email protected]> Co-authored-by: Behrokh Satarnejad <[email protected]> Co-authored-by: camertron <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s group (primer#3252) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jon Rohan <[email protected]>
…dencies group (primer#3248) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: a9df370 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
myabc
force-pushed
the
bump/primer-upstream
branch
2 times, most recently
from
83aeabd to
d748aa9
Compare
myabc
force-pushed
the
bump/primer-upstream
branch
from
d748aa9 to
302f550
Compare
myabc
commented
Jan 17, 2025
| @@ -0,0 +1 @@ | |||
| - 'button "Translation missing: en.label_zen_mode"' No newline at end of file | |||
|
Hi @myabc thanks 👍 I don't see any issue in app/lib/primer/forms/text_field.rb. All good! |
HDinger
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎆 This brings in two upstream patches we contributed + fix for a memory leak that @cbliard reported:
primer#3267
primer#3265
primer#3259
ℹ️ N.B. there was a conflict in
app/lib/primer/forms/text_field.rbthat I needed to resolve manually. Our implementation ofPrimer::Alpha::TextFielddiffers slightly from the upstream component - we support a customwidthattribute (see PR #48 / 102a2ee)@bsatarnejad I'd be grateful if you could double-check since this relates to the trailing visuals functionality introduced in primer#3267.