Show authentication provider create message #20475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
changed the title
NobodysNightmare
force-pushed
the
oidc-provider-create-message
branch
from
8566088 to
dbf366e
Compare
NobodysNightmare
changed the title
|
Ignoring further Rubocop complaints, because they address existing/previous issues that I am not planning to fix today. |
NobodysNightmare
force-pushed
the
oidc-provider-create-message
branch
from
905dbbd to
c952c20
Compare
So far we didn't redirect the user anywhere and they couldn't know that they successfully created their provider. Now we redirect them to the show view and display a success message. As part of this change the "edit mode" was renamed to "new mode", because it's exclusively set to true during initial provider creation, so it's rather reflecting on being tied to the "new" user flow, than to any "edit" user flow.
Also here (similar to OIDC), the old terminology was rather confusing, because this mode was exclusively set from the #new action, but it was never set during editing of a provider at a later point.
This allows them to see the sidebar that's regularly part of the show view and only hidden during the initial creation of a provider. For that we needed to change the show action to not render a turbostream response anymore. This behaviour is now consistent with the OpenID Connect provider controller again.
Extracting method, mostly for the purpose of making Rubocop a bit happier, but also hoping that it helps in readability.
NobodysNightmare
force-pushed
the
oidc-provider-create-message
branch
from
df22535 to
66def0c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we didn't redirect the user anywhere and they couldn't know
that they successfully created their provider. Now we redirect them
to the show view and display a success message.
As part of this change the "edit mode" was renamed to "new mode", because
it's exclusively set to true during initial provider creation, so it's rather
reflecting on being tied to the "new" user flow, than to any "edit" user flow.
Those changes were applied to both OpenID Connect providers and SAML providers.
Ticket
https://community.openproject.org/wp/67257