Skip to content

Commit 028dcd1

Browse files
zzzariescopybara-github
authored andcommitted
No-op changes.
remove unused constant. PiperOrigin-RevId: 799312901
1 parent 1d24fc2 commit 028dcd1

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

frontend/app/common/constants/constants.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,6 @@ export const GRAPH_TYPE_DEFAULT = 'xla';
8383
export const HLO_TOOLS =
8484
['memory_viewer', 'graph_viewer'];
8585

86-
/** The query parameter keys used in trace viewer */
87-
// TODO(yinzz): update the key in tf-trace-viewr.html to this one for
88-
// consistency
89-
export const TRACE_VIEWER_QUERY_PARAMS_KEYS = {
90-
'host': 'host',
91-
};
92-
9386
/** The query parameter keys used in graph viewer */
9487
export const GRAPHVIZ_PAN_ZOOM_CONTROL = '&pan_zoom=1&pan_zoom_controls=1';
9588

plugin/trace_viewer/tf_trace_viewer/tf-trace-viewer.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1389,8 +1389,12 @@
13891389

13901390
_perfettoButtonOnclickCallback: function() {
13911391
const sessionPerfettoUrl = new URL(`/perfetto/${this._sessionId}`, window.location.href);
1392-
if (this._selectedHosts.length) {
1393-
sessionPerfettoUrl.searchParams.set('hosts', this._selectedHosts.join(','));
1392+
const relatedParams = ['host', 'hosts', 'host_index', 'trace_filter_config'];
1393+
for (const param of relatedParams) {
1394+
const value = this._buildBaseURL().searchParams.get(param);
1395+
if (value) {
1396+
sessionPerfettoUrl.searchParams.set(param, value);
1397+
}
13941398
}
13951399
window.open(sessionPerfettoUrl.toString());
13961400
},

0 commit comments

Comments
 (0)