Skip to content

Commit 2359644

Browse files
UTIL: fix rcache merge cb (#1011)
1 parent 777df69 commit 2359644

File tree

5 files changed

+24
-3
lines changed

5 files changed

+24
-3
lines changed

config/m4/ucx.m4

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ AS_IF([test "x$ucx_checked" != "xyes"],[
119119
[],
120120
[#include <ucs/memory/rcache.h>])
121121
122+
AC_CHECK_MEMBER(ucs_rcache_ops_t.merge,
123+
[AC_DEFINE([UCS_HAVE_RCACHE_MERGE_CB], [1], [flags for ucs_rcache_ops_t])],
124+
[],
125+
[#include <ucs/memory/rcache.h>])
126+
122127
AC_DEFINE([HAVE_UCX], 1, [Enable UCX support])
123128
124129
AC_COMPILE_IFELSE([AC_LANG_SOURCE([[#include <ucs/config/parser.h>

src/components/tl/mlx5/mcast/tl_mlx5_mcast_rcache.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,10 @@ void ucc_tl_mlx5_mcast_mem_deregister(ucc_tl_mlx5_mcast_coll_context_t *ctx,
130130
static ucc_rcache_ops_t ucc_tl_mlx5_rcache_ops = {
131131
.mem_reg = ucc_tl_mlx5_mcast_rcache_mem_reg_cb,
132132
.mem_dereg = ucc_tl_mlx5_mcast_rcache_mem_dereg_cb,
133-
.dump_region = ucc_tl_mlx5_mcast_rcache_dump_region_cb
133+
.dump_region = ucc_tl_mlx5_mcast_rcache_dump_region_cb,
134+
#ifdef UCS_HAVE_RCACHE_MERGE_CB
135+
.merge = ucc_rcache_merge_cb_empty
136+
#endif
134137
};
135138

136139
ucc_status_t ucc_tl_mlx5_mcast_setup_rcache(ucc_tl_mlx5_mcast_coll_context_t *ctx)

src/components/tl/mlx5/tl_mlx5_rcache.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ static void ucc_tl_mlx5_rcache_dump_region_cb(void *context, //NOLINT
5555
static ucc_rcache_ops_t ucc_tl_mlx5_rcache_ops = {
5656
.mem_reg = rcache_reg_mr,
5757
.mem_dereg = rcache_dereg_mr,
58-
.dump_region = ucc_tl_mlx5_rcache_dump_region_cb
58+
.dump_region = ucc_tl_mlx5_rcache_dump_region_cb,
59+
#ifdef UCS_HAVE_RCACHE_MERGE_CB
60+
.merge = ucc_rcache_merge_cb_empty
61+
#endif
5962
};
6063

6164
ucc_status_t tl_mlx5_rcache_create(ucc_tl_mlx5_context_t *ctx)

src/components/tl/sharp/tl_sharp_context.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,10 @@ ucc_tl_sharp_rcache_dump_region_cb(void *context, ucs_rcache_t *rcache, //NOLINT
261261
static ucc_rcache_ops_t ucc_tl_sharp_rcache_ops = {
262262
.mem_reg = ucc_tl_sharp_rcache_mem_reg_cb,
263263
.mem_dereg = ucc_tl_sharp_rcache_mem_dereg_cb,
264-
.dump_region = ucc_tl_sharp_rcache_dump_region_cb
264+
.dump_region = ucc_tl_sharp_rcache_dump_region_cb,
265+
#ifdef UCS_HAVE_RCACHE_MERGE_CB
266+
.merge = ucc_rcache_merge_cb_empty
267+
#endif
265268
};
266269

267270
ucc_status_t ucc_tl_sharp_rcache_create(struct sharp_coll_context *context,

src/utils/ucc_rcache.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,13 @@ static inline void ucc_rcache_set_default_params(ucs_rcache_params_t *rcache_par
3535
#define ucc_rcache_region_put ucs_rcache_region_put
3636
#define ucc_rcache_region_invalidate ucs_rcache_region_invalidate
3737

38+
static inline void
39+
ucc_rcache_merge_cb_empty(void *context, ucs_rcache_t *rcache,
40+
void *arg, ucs_rcache_region_t *region)
41+
{
42+
return;
43+
}
44+
3845
/* Wrapper functions for status conversion */
3946
static inline ucc_status_t
4047
ucc_rcache_create(const ucc_rcache_params_t *params,

0 commit comments

Comments
 (0)