Skip to content

Commit 9d00c38

Browse files
Merge pull request #327 from sanchezl/image-version
report correct version when multiple images invoked
2 parents 80cb6f0 + ce8eca9 commit 9d00c38

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

collection-scripts/gather

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# generate /must-gather/version file
44
. version
5-
echo "openshift/must-gather" > /must-gather/version
5+
echo "openshift/must-gather"> /must-gather/version
66
version >> /must-gather/version
77

88
# Named resource list, eg. ns/openshift-config

collection-scripts/version

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
11
#!/usr/bin/env bash
22

33
function version() {
4-
# get version from image
5-
version=$( \
6-
oc status | grep '^pod' | \
7-
sed -n -r -e 's/.*([[:digit:]]+\.[[:digit:]]+(:?\.[[:digit:]])?(:?-[^@]+)?).*/\1/p' \
8-
)
9-
10-
# if version not found, fallback to imageID
11-
[ -z "${version}" ] && version=$(oc status | grep '^pod.*runs' | sed -r -e 's/^pod.*runs //')
12-
13-
# if version still not found, use Unknown
14-
[ -z "${version}" ] && version="Unknown"
15-
16-
echo ${version}
4+
if [[ ! -z $OS_GIT_VERSION ]] ; then
5+
echo "${OS_GIT_VERSION}"
6+
else
7+
echo "0.0.0-unknown"
8+
fi
179
}

0 commit comments

Comments
 (0)