SREP-1120: Test - Create ClusterDeployment Resource (ClusterDeployment has created but no primary-cert-bundle-secret found) #379
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ratnam915: This pull request references SREP-1120 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 57.15% 57.15%
=======================================
Files 29 29
Lines 2138 2138
=======================================
Hits 1222 1222
Misses 802 802
Partials 114 114 🚀 New features to boost your workflow:
|
|
/test all |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ratnam915 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ratnam915
force-pushed
the
feature/SREP-1120
branch
2 times, most recently
from
29c04ac to
a9d7b38
Compare
|
Successful execution of test cases carried out by building the e2e test image. Attached is the output for the same. (https://github.com/user-attachments/files/22619368/output2.txt) |
|
nit not touched by this PR but related:
looks like your branch is outdated, a rebase should help! |
ratnam915
force-pushed
the
feature/SREP-1120
branch
from
a9d7b38 to
0050871
Compare
… made changes accordingly
|
can we separate the boilerplate update and the code change? |
ratnam915
force-pushed
the
feature/SREP-1120
branch
from
274a32a to
23882f1
Compare
ratnam915
force-pushed
the
feature/SREP-1120
branch
from
23882f1 to
263e1aa
Compare
|
/test all |
|
/test validate |
|
@ratnam915: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| "metadata": map[string]interface{}{ | ||
| "name": clusterDeploymentName, | ||
| "namespace": config.TestNamespace, | ||
| "labels": map[string]interface{}{ |
There was a problem hiding this comment.
do you know if all the labels here are required?
| "hive.openshift.io/version-major": "4", | ||
| "hive.openshift.io/version-major-minor": "4.19", | ||
| }, | ||
| "annotations": map[string]interface{}{ |
There was a problem hiding this comment.
and also the annotations here as well
| } | ||
| } | ||
|
|
||
| func VerifyMetrics(ctx context.Context, dynamicClient dynamic.Interface, certificateRequestGVR schema.GroupVersionResource, namespace string) (int, bool) { |
There was a problem hiding this comment.
What does the function name mean? What kind of metric we are verifying?
|
|
||
| // Return true if any CertificateRequests exist | ||
| return len(crList.Items) > 0 | ||
| }, pollingDuration, 30*time.Second).Should(gomega.BeTrue(), "CertificateRequest should be created by operator") |
There was a problem hiding this comment.
Do we need to check the name of certificaterequest here?
| }) | ||
|
|
||
| ginkgo.It("should verify certificate operation metrics", func(ctx context.Context) { | ||
| ginkgo.GinkgoLogr.Info("=== Test: Verifying Certificate Operation Metrics ===") |
There was a problem hiding this comment.
I feel the metrics here is a bit misleading, as the metrics in kubernetes have the special mean usually
6 participants
Redirected from #357 to minimize conflicting changes