Remove "Check Datasets" step

This is now superseded by the ehrQL permissions system:
 * opensafely-core/ehrql#2543

Author: evansd

.github/workflows/tests.yml

@@ -134,34 +134,3 @@ jobs:
                 echo "Action should have failed with codelists error"
                 exit 1
             fi
-
-  test-check:
-    runs-on: ubuntu-20.04
-    name: Test dataset check failure
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Test project with failing codelists check
-        uses: ./
-        id: dataset
-        continue-on-error: true
-        with:
-            directory: tests/dataset
-            users: '@nobody' 
-      - name: Assert check failed and created issue
-        env:
-            ISSUE_URL: ${{ steps.dataset.outputs.issue }}
-        run: |
-            fail() { 
-                echo "$@"
-                exit 1
-            }
-            cleanup() { 
-                gh issue close "$ISSUE_URL" || true
-            }
-            trap cleanup EXIT
-            test "${{ steps.dataset.outcome }}" = "failure" || fail "Action should have failed with dataset error"
-            test -n "$ISSUE_URL" || fail "No issue url output from dataset step"
-            gh issue view "$ISSUE_URL" || fail "Could not view issue at $ISSUE_URL"
-
-

action.yml

@@ -6,10 +6,6 @@ inputs:
     description: "Directory containing OpenSAFELY project"
     required: false
     default: . 
-  users:
-    description: "@names of users who should be notified on dataset failure"
-    required: false
-    default: "@amirmehrkar @JulietUnderdown1 @LiamHart-hub @alexwalkerepi"
   actions:
     description: "Names of project actions to run during tests (default 'run_all')"
     required: false
@@ -32,31 +28,6 @@ runs:
       shell: bash
       working-directory: ${{ inputs.directory }}
       run: opensafely codelists check
-    - name: Check datasets
-      shell: bash
-      id: datasets
-      working-directory: ${{ inputs.directory }}
-      run: |
-        success=true
-        OUTPUT=$(opensafely check 2>&1) || success=false
-        echo "$OUTPUT"
-        # exit early if we're all good
-        test "$success" = "true" && exit 0
-
-        BODY=$(cat << EOF
-        Dataset check for $GITHUB_REPOSITORY at $GITHUB_SHA:
-        \`\`\`
-        $OUTPUT
-        \`\`\`
-        ${{ inputs.users }}
-        EOF
-        )
-
-        ISSUE_URL=$(gh issue create --title "Dataset check fail" --body "$BODY")
-
-        echo "Created issue at $ISSUE_URL"
-        echo "::set-output name=issue::$ISSUE_URL"
-        exit 1
     - name: Run project
       shell: bash
       working-directory: ${{ inputs.directory }}