Skip to content

Make local missing permissions a hard error rather than a warning #2553

@evansd

Description

@evansd

A permissions system was added to ehrQL in:

The plan is for local ehrQL runs to fail immediately and loudly when a table or feature is used which requires special permission. The error message should provide clear instructions on what to do next so this shouldn't be a blocker for the user. But the aim is that no user should get to the stage of trying to run something for real and only then discover that the thing they are trying to do requires extra permissions.

However, to allow for a smooth rollout of the permissions changes we have initially only made this a warning – which is easy to miss if you're not looking at your ehrQL logs.

At some appropriate point we should change this warning to an error. We'll need to decide exactly what counts as "appropriate" here. But Will suggests that we don't need to be too anxious here:

However, i wouldn't be too worried about giving everyone a chance to update their code without being suddenly forced to do so. It would be a quick fix and it's easy to support the relatively small number of users affected by this

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions