-
Notifications
You must be signed in to change notification settings - Fork 171
8350813: Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
The failed CertPathValidator tests don't look related to the change. |
|
@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@wkia The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
/approval request I'd like to backport this as the problem also exists in jdk8. This is almost clean backport, resolved conflict in copyright. Test fails before the fix, and passes with the fix. |
This is backport of "JDK-8350813 Rendering of bulky sound bank from MIDI sequence can cause OutOfMemoryError"
The problem exists in jdk8 also.
Almost clean backport, resolved conflict in copyright, and put
BulkSoundBank.javatojdk/test/javax/sound/midi/BulkSoundBank/.Test fails before the fix, and passes with the fix.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/702/head:pull/702$ git checkout pull/702Update a local copy of the PR:
$ git checkout pull/702$ git pull https://git.openjdk.org/jdk8u-dev.git pull/702/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 702View PR using the GUI difftool:
$ git pr show -t 702Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/702.diff
Using Webrev
Link to Webrev Comment