-
Notifications
You must be signed in to change notification settings - Fork 5
feat(settings): allow users upload logo and favicon #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b072d82 to
571958b
Compare
adriangohjw
reviewed
Oct 31, 2025
apps/studio/src/features/editing-experience/components/EditSettingsPreview.tsx
Outdated
Show resolved
Hide resolved
apps/studio/src/features/editing-experience/components/EditSettingsPreview.tsx
Outdated
Show resolved
Hide resolved
apps/studio/src/features/editing-experience/components/EditSettingsPreview.tsx
Show resolved
Hide resolved
b7a74dc to
3cacd12
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
3516170 to
c7766d4
Compare
dcshzj
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Site administrators need the ability to customize their site's logo and favicon through the Isomer Studio interface. Previously, these settings were hidden in the site configuration and couldn't be easily updated through the UI.
Solution
Added a new "Logos and favicon" settings page that allows users to:
Breaking Changes
Features:
/sites/[siteId]/settings/logofor managing logo and faviconLogoSettingsSchemafrom the main site config for better separation of concernsImprovements:
resourceIdparameter optional inFileAttachmentcomponent (instead of forcing string conversion from potentially undefined values)filename*=UTF-8'')LinkEditorModalandJsonFormsImageControlby conditionally passingresourceIdBug Fixes:
datacould be undefinedTests
Testing checklist:
logo (1).png,favicon 图标.ico,site-logo–2024.svg)New scripts: None
New dependencies: None
New dev dependencies: None
Technical Notes
Schema Changes
LogoSettingsSchemafromSiteConfigSchemain the components packageupdateSiteConfigSchemato validate the full site config using the TypeBox validatorFile Upload Fix
Changed from:
To:
This follows RFC 6266 specification for internationalized filenames.
Preview Component
Added a
ChromeTabcomponent that renders a browser tab preview showing how the favicon appears alongside the site name. This can be toggled via theshowChromeTabprop onEditSettingsPreview.