Skip to content

[Feature] Create import data process #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexjustesen opened this issue Feb 10, 2025 · 3 comments
Open

[Feature] Create import data process #30

alexjustesen opened this issue Feb 10, 2025 · 3 comments
Assignees
Labels
🎉 feature New feature or request
Milestone

Comments

@alexjustesen
Copy link
Collaborator

alexjustesen commented Feb 10, 2025

📃 Description

https://github.com/openbrewerydb/openbrewerydb is refreshed periodically with new brewery data, the API should either be made aware of updates or retrieve the latest dataset automatically.

🤔 Potential Methods

👉 Push

  1. Data repo pings the application when a new dataset is released.
  2. Application makes a backup of the current database.
  3. Application pulls in the latest data and imports it.

👈 Pull

  1. Application makes a backup of the current database.
  2. Application pulls the latest data on a schedule and imports it.
@alexjustesen alexjustesen added the 🎉 feature New feature or request label Feb 10, 2025
@alexjustesen alexjustesen self-assigned this Feb 10, 2025
@alexjustesen
Copy link
Collaborator Author

Landed on "push" this way the container ships as a complete application and data package. This will rely on setting up #44 in the data repo so it triggers builds and deployments of the API.

@chrisjm
Copy link
Collaborator

chrisjm commented Feb 23, 2025

@alexjustesen Actually, for now, I'd prefer a manual push process mostly because I would like to keep the data and API projects separate and not necessarily rely on one another.

@alexjustesen
Copy link
Collaborator Author

I'll leave this open to document the process and decision.

I think we just need to button up the list endpoint and tests and we're probably good to go.

@alexjustesen alexjustesen added this to the v2 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants