Skip to content

Conversation

@Harold-lkk
Copy link
Contributor

@Harold-lkk Harold-lkk commented Feb 15, 2023

Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please add api docs

@Harold-lkk Harold-lkk requested review from C1rN09 February 17, 2023 05:44
@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch 2 times, most recently from fb98732 to 885d5f1 Compare February 28, 2023 07:06
@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch from 885d5f1 to f36c20d Compare March 6, 2023 02:29
@Harold-lkk Harold-lkk requested a review from C1rN09 March 6, 2023 02:30
@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch from f36c20d to 33d5350 Compare March 7, 2023 02:36
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should rebase to main branch to fix CI

@Harold-lkk Harold-lkk force-pushed the lkk/CharRecallPrecision branch from 33d5350 to bace3bc Compare March 13, 2023 08:46
@zhouzaida zhouzaida merged commit a9cf49b into open-mmlab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants