Skip to content

Conversation

fl-ido
Copy link

@fl-ido fl-ido commented Sep 2, 2025

validateSigningCert method allows to bypass certificate trust check during signature verification.

Fixes #678

Signed-off-by: Florian Dargère [email protected]

validateSigningCert method allows to bypass certificate trust check
during signature verification.

Fixes open-eid#678

Signed-off-by: Florian Dargère <[email protected]>
@metsma
Copy link
Contributor

metsma commented Sep 2, 2025

Can you explain the reason?

@fl-ido
Copy link
Author

fl-ido commented Sep 2, 2025

It allows to avoid checking the trust status of the signing certificate during signature verification, thus allowing the user to verify the trust status by himself, possibly using another store than TSL. The aim is to be able to verify signatures which have been signed with a certificate trusted from another source than TSL. It is an answer to #678 and #556 as well. I think it has to be a configuration parameter, in order to be customizable. Thus, I guess it needs a new configuration class, for binary compatibility.

@metsma
Copy link
Contributor

metsma commented Sep 2, 2025

Maybe we should figure out how to make X509CertStore usable as public API?

@fl-ido
Copy link
Author

fl-ido commented Sep 2, 2025

Do you mean by making the X509CertStore::verify function virtual so that custom implementations could override the method with their own verification process ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling of certificate check during signature verification
2 participants