fix: improve TagPigeon export to support ISO 14443 NFC tags on Android #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an issue while working with NFC cards that are not NDEF compatible but follow the ISO 14443 standard. When trying to read data from such tags using the
nfc_managerpackage on Android, the output was"instance of TagPigeon"instead of the actual tag data.To fix this, I exported
pigeon.g.dartproperly to enable direct access to the tag's low-level data, allowing correct handling and parsing of ISO 14443 tags.This change improves compatibility with a wider range of NFC tags that are commonly used but not NDEF formatted.
For example, to get the tag ID, you can now do: