Skip to content

[v2.3.x] prov/efa: Log warnings only for internal OPE failures or if … #11546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

[v2.3.x] prov/efa: Log warnings only for internal OPE failures or if … #11546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions prov/efa/src/rdm/efa_rdm_ope.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ void efa_rdm_rxe_handle_error(struct efa_rdm_ope *rxe, int err, int prov_errno)
err_entry.err_data = err_msg;
}

EFA_WARN(FI_LOG_CQ, "err: %d, message: %s (%d)\n",
EFA_INFO(FI_LOG_CQ, "err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
Expand All @@ -663,6 +663,14 @@ void efa_rdm_rxe_handle_error(struct efa_rdm_ope *rxe, int err, int prov_errno)
//efa_rdm_rxe_release(rxe);

if (rxe->internal_flags & EFA_RDM_OPE_INTERNAL) {
EFA_WARN(FI_LOG_CQ, "EFA provider internal rxe failure err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
: efa_strerror(err_entry.prov_errno),
err_entry.prov_errno);
efa_show_help(err_entry.prov_errno);

EFA_WARN(FI_LOG_CQ,
"Writing eq error for rxe from internal operations\n");
efa_base_ep_write_eq_error(&ep->base_ep, err, prov_errno);
Expand All @@ -672,6 +680,14 @@ void efa_rdm_rxe_handle_error(struct efa_rdm_ope *rxe, int err, int prov_errno)
efa_cntr_report_error(&ep->base_ep.util_ep, err_entry.flags);
write_cq_err = ofi_cq_write_error(util_cq, &err_entry);
if (write_cq_err) {
EFA_WARN(FI_LOG_CQ, "Failed to write CQ error entry for rxe err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
: efa_strerror(err_entry.prov_errno),
err_entry.prov_errno);
efa_show_help(err_entry.prov_errno);

EFA_WARN(FI_LOG_CQ,
"Error writing error cq entry when handling RX error\n");
efa_base_ep_write_eq_error(&ep->base_ep, err, prov_errno);
Expand Down Expand Up @@ -757,7 +773,7 @@ void efa_rdm_txe_handle_error(struct efa_rdm_ope *txe, int err, int prov_errno)
err_entry.err_data = err_msg;
}

EFA_WARN(FI_LOG_CQ, "err: %d, message: %s (%d)\n",
EFA_INFO(FI_LOG_CQ, "err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
Expand All @@ -774,6 +790,15 @@ void efa_rdm_txe_handle_error(struct efa_rdm_ope *txe, int err, int prov_errno)
//efa_rdm_txe_release(txe);

if (txe->internal_flags & EFA_RDM_OPE_INTERNAL) {
EFA_WARN(FI_LOG_CQ, "EFA provider internal txe failure err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
: efa_strerror(err_entry.prov_errno),
err_entry.prov_errno);

efa_show_help(err_entry.prov_errno);

EFA_WARN(FI_LOG_CQ,
"Writing eq error for txe from internal operations\n");
efa_base_ep_write_eq_error(&ep->base_ep, err, prov_errno);
Expand All @@ -783,6 +808,15 @@ void efa_rdm_txe_handle_error(struct efa_rdm_ope *txe, int err, int prov_errno)
efa_cntr_report_error(&ep->base_ep.util_ep, txe->cq_entry.flags);
write_cq_err = ofi_cq_write_error(util_cq, &err_entry);
if (write_cq_err) {
EFA_WARN(FI_LOG_CQ, "Failed to write CQ error entry for txe err: %d, message: %s (%d)\n",
err_entry.err,
err_entry.err_data
? (const char *) err_entry.err_data
: efa_strerror(err_entry.prov_errno),
err_entry.prov_errno);

efa_show_help(err_entry.prov_errno);

EFA_WARN(FI_LOG_CQ,
"Error writing error cq entry when handling TX error\n");
efa_base_ep_write_eq_error(&ep->base_ep, err, prov_errno);
Expand Down