Skip to content

Commit 3300475

Browse files
Eugene ButEugene But
authored andcommitted
Call WebState::WasHidden on Tab removal.
The primary purpose of this CL is to fix a bug, when Download Manager UI persists after closing and reopening a tab. There is an alternative fix which is to dismiss Download Manager UI in DownloadManagerTabHelper::WebStateWasDestroyed, but calling WebState::WasHidden for closed WebState sounds like the right approach in general. [email protected] (cherry picked from commit 6ebb327) Bug: 919974 Change-Id: I204514995d616297b0745763dcd5acc21afef678 Reviewed-on: https://chromium-review.googlesource.com/c/1433497 Auto-Submit: Eugene But <[email protected]> Reviewed-by: edchin <[email protected]> Commit-Queue: Eugene But <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#626608} Reviewed-on: https://chromium-review.googlesource.com/c/1444140 Reviewed-by: Eugene But <[email protected]> Cr-Commit-Position: refs/branch-heads/3683@{#56} Cr-Branched-From: e510299-refs/heads/master@{#625896}
1 parent 78c2b66 commit 3300475

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

ios/chrome/browser/ui/browser_view_controller.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4529,6 +4529,8 @@ - (void)tabModel:(TabModel*)model
45294529
- (void)tabModel:(TabModel*)model
45304530
didRemoveTab:(Tab*)tab
45314531
atIndex:(NSUInteger)index {
4532+
tab.webState->WasHidden();
4533+
45324534
[self uninstallDelegatesForTab:tab];
45334535

45344536
// Cancel dialogs for |tab|'s WebState.

0 commit comments

Comments
 (0)