Commit 105c463
Revert "Fix WebRequestProxyingURLLoaderFactory crash after redirect"
This reverts commit 066fecf.
Reason for revert: This change had some unintended effects on the interaction of WebRequest and URLLoaderThrottles.
Original change's description:
> Fix WebRequestProxyingURLLoaderFactory crash after redirect
>
> When OnReceiveRedirect() is called, we expect to not receive any more
> events for that request until FollowRedirect() has been called and the
> request is restarted with the new URL. We were not clearing the
> bindings in this case, so the URLLoader was staying alive and calling
> OnBeforeSendHeaders() on the redirected URL. This could then result in
> OnBeforeSendHeaders() being called twice, once for the original request
> which gets redirected in //net, and once for the request in the correct
> flow when it gets restarted after FollowRedirect().
>
> I believe this is pretty similar to the issue described in
> http://crbug.com/882661, except this one has to do with normal
> redirects instead of webRequest generated redirects.
>
> The existing redirect tests catch this issue when using the
> 'extraHeaders' spec, so I made a version of them that runs with that
> enabled.
>
> Bug: 918761
> Change-Id: Ifa551400e85c13ea3a297fba02a05deb5ccb1821
> Reviewed-on: https://chromium-review.googlesource.com/c/1409915
> Reviewed-by: Ken Rockot <[email protected]>
> Commit-Queue: Clark DuVall <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#622685}
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 918761
Change-Id: Ie8449c6fd6c94722ef8eb618ea1a16d429b74bbb
Reviewed-on: https://chromium-review.googlesource.com/c/1443913
Reviewed-by: Clark DuVall <[email protected]>
Reviewed-by: John Abd-El-Malek <[email protected]>
Commit-Queue: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#627183}(cherry picked from commit 6406a9f)
Reviewed-on: https://chromium-review.googlesource.com/c/1444812
Cr-Commit-Position: refs/branch-heads/3683@{#54}
Cr-Branched-From: e510299-refs/heads/master@{#625896}1 parent f506ced commit 105c463
File tree
4 files changed
+346
-362
lines changed- chrome
- browser/extensions/api/web_request
- test/data/extensions/api_test/webrequest
- extensions/browser/api/web_request
4 files changed
+346
-362
lines changedLines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
556 | 556 | | |
557 | 557 | | |
558 | 558 | | |
559 | | - | |
560 | | - | |
561 | | - | |
562 | | - | |
563 | | - | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | 559 | | |
568 | 560 | | |
569 | 561 | | |
| |||
596 | 588 | | |
597 | 589 | | |
598 | 590 | | |
599 | | - | |
600 | | - | |
601 | | - | |
602 | | - | |
603 | | - | |
604 | | - | |
605 | | - | |
606 | | - | |
607 | 591 | | |
608 | 592 | | |
609 | 593 | | |
| |||
0 commit comments