fix: use focusable as window filter for refresh() #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It seems some popups have the property of focusable. That will make winbar shown in undesired window. Working on an alternative solution. |
henry-hsieh
force-pushed
the
fix-refresh-filter
branch
from
60cec6d to
c3d8d88
Compare
Author
|
Also check modifiable for most info popup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic uses
win_gettype()to check the window type. However, not all popup windows do not have winbar. For example, detour.nvim uses float windows to navigate between positions, orzencomponent of snacks.nvim uses a float window as zoomed/zen window. When a windows is focusable, it may want to show the winbar.