Address feedback

nvdaes · nvdaes · commit bb03c8316ecb · 2025-10-07T21:39:56.000+02:00
diff --git a/_validate/createJson.py b/_validate/createJson.py
@@ -132,10 +132,14 @@ def _createDataclassMatchingJsonSchema(
 
 		# Add optional translated changelog.
 		translatedChangelog = translatedManifest.get("changelog")  # type: ignore[reportUnknownMemberType]
+		if translatedChangelog == "None":
+			# The config default is None
+			# which is parsed by configobj as a string not a NoneType
+			translatedChangelog = None
 		if translatedChangelog:
 			translations.append(
 				{
-					"changelog": cast(str, translatedChangelog),
+					"changelog": translatedChangelog,
 				},
 			)
 

Original file line number	Diff line number	Diff line change
`@@ -132,10 +132,14 @@ def _createDataclassMatchingJsonSchema(`
`132`	`132`
`133`	`133`	`# Add optional translated changelog.`
`134`	`134`	`translatedChangelog = translatedManifest.get("changelog") # type: ignore[reportUnknownMemberType]`
	`135`	`+ if translatedChangelog == "None":`
	`136`	`+ # The config default is None`
	`137`	`+ # which is parsed by configobj as a string not a NoneType`
	`138`	`+ translatedChangelog = None`
`135`	`139`	`if translatedChangelog:`
`136`	`140`	`translations.append(`
`137`	`141`	`{`
`138`		`- "changelog": cast(str, translatedChangelog),`
	`142`	`+ "changelog": translatedChangelog,`
`139`	`143`	`},`
`140`	`144`	`)`
`141`	`145`