Skip to content

Support for ShapeNet V2 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lalalune opened this issue Oct 5, 2022 · 2 comments
Closed

Support for ShapeNet V2 #12

lalalune opened this issue Oct 5, 2022 · 2 comments

Comments

@lalalune
Copy link

lalalune commented Oct 5, 2022

Question--

  1. is there any reason, other than normalizing folder structure, that ShapeNetCore V2 wouldn't work, or reason you chose ShapeNet V1 for the release?
  2. Would you accept a PR for support for ShapeNet V2?
@SteveJunGao
Copy link
Collaborator

Hi @lalalune

Re 1: Technically speaking, ShapeNetCore v2 should also work, we didn't have specific requirements on the dataset. We choose to release the support for ShapeNetCore v1 as our paper is mainly experimenting with it.

Re 2: Yes, we're happy to accept a PR for it

@lalalune
Copy link
Author

lalalune commented Oct 8, 2022

I have added details in this pr: #17

@lalalune lalalune closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SteveJunGao @lalalune