Skip to content

Commit e08c981

Browse files
committed
what happens if you disable test
1 parent 34dcdf3 commit e08c981

File tree

1 file changed

+46
-45
lines changed

1 file changed

+46
-45
lines changed

test/fetch/cookies.js

Lines changed: 46 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
'use strict'
22

3-
const { strictEqual, deepStrictEqual } = require('node:assert').strict
3+
const { strictEqual } = require('node:assert').strict
44
const { once } = require('node:events')
55
const { createServer } = require('node:http')
66
const { test, describe, before, after } = require('node:test')
77
const { stringify: qsStringify } = require('node:querystring')
8-
const { Client, fetch, Headers } = require('../..')
9-
const pem = require('@metcoder95/https-pem')
10-
const { createSecureServer } = require('node:http2')
8+
const { fetch, Headers } = require('../..')
9+
// const { Client, fetch, Headers } = require('../..')
10+
// const pem = require('@metcoder95/https-pem')
11+
// const { createSecureServer } = require('node:http2')
1112

1213
describe('cookies', () => {
1314
let server
@@ -25,7 +26,7 @@ describe('cookies', () => {
2526
})
2627

2728
after(() => {
28-
setImmediate(() => server.close())
29+
server.close()
2930
})
3031

3132
test('Can receive set-cookie headers from a server using fetch - issue #1262', async () => {
@@ -70,44 +71,44 @@ describe('cookies', () => {
7071
strictEqual(await response.text(), 'FOO=lorem-ipsum-dolor-sit-amet; BAR=the-quick-brown-fox')
7172
})
7273

73-
test('Can receive set-cookie headers from a http2 server using fetch - issue #2885', async () => {
74-
const server = createSecureServer(pem)
75-
server.on('stream', (stream, headers) => {
76-
stream.respond({
77-
'content-type': 'text/plain; charset=utf-8',
78-
'x-method': headers[':method'],
79-
'set-cookie': 'Space=Cat; Secure; HttpOnly',
80-
':status': 200
81-
})
82-
83-
stream.end('test')
84-
})
85-
86-
await once(server.listen(0), 'listening')
87-
88-
const client = new Client(`https://localhost:${server.address().port}`, {
89-
connect: {
90-
rejectUnauthorized: false
91-
},
92-
allowH2: true
93-
})
94-
95-
const response = await fetch(
96-
`https://localhost:${server.address().port}/`,
97-
// Needs to be passed to disable the reject unauthorized
98-
{
99-
method: 'GET',
100-
dispatcher: client,
101-
headers: {
102-
'content-type': 'text-plain'
103-
}
104-
}
105-
)
106-
107-
deepStrictEqual(response.headers.getSetCookie(), ['Space=Cat; Secure; HttpOnly'])
108-
strictEqual(await response.text(), 'test')
109-
110-
await client.close()
111-
await new Promise((resolve, reject) => server.close(err => err ? reject(err) : resolve()))
112-
})
74+
// test('Can receive set-cookie headers from a http2 server using fetch - issue #2885', async () => {
75+
// const server = createSecureServer(pem)
76+
// server.on('stream', (stream, headers) => {
77+
// stream.respond({
78+
// 'content-type': 'text/plain; charset=utf-8',
79+
// 'x-method': headers[':method'],
80+
// 'set-cookie': 'Space=Cat; Secure; HttpOnly',
81+
// ':status': 200
82+
// })
83+
84+
// stream.end('test')
85+
// })
86+
87+
// await once(server.listen(0), 'listening')
88+
89+
// const client = new Client(`https://localhost:${server.address().port}`, {
90+
// connect: {
91+
// rejectUnauthorized: false
92+
// },
93+
// allowH2: true
94+
// })
95+
96+
// const response = await fetch(
97+
// `https://localhost:${server.address().port}/`,
98+
// // Needs to be passed to disable the reject unauthorized
99+
// {
100+
// method: 'GET',
101+
// // dispatcher: client,
102+
// headers: {
103+
// 'content-type': 'text-plain'
104+
// }
105+
// }
106+
// )
107+
108+
// deepStrictEqual(response.headers.getSetCookie(), ['Space=Cat; Secure; HttpOnly'])
109+
// strictEqual(await response.text(), 'test')
110+
111+
// await client.close()
112+
// await new Promise((resolve, reject) => server.close(err => err ? reject(err) : resolve()))
113+
// })
113114
})

0 commit comments

Comments
 (0)