Skip to content

sqlite: handle ?NNN bind params as positional #59350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sqlite: handle ?NNN bind params as positional #59350

wants to merge 1 commit into from
+33 −1

Conversation

geeksilva97
Copy link
Contributor

Fixes #59340

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 4, 2025
@geeksilva97 geeksilva97 added the blocked PRs that are blocked by other issues or PRs. label Aug 4, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.37%. Comparing base (b8e6432) to head (f74e6dc).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59350      +/-   ##
==========================================
+ Coverage   89.35%   89.37%   +0.02%     
==========================================
  Files         654      654              
  Lines      192554   192702     +148     
  Branches    37432    37456      +24     
==========================================
+ Hits       172050   172222     +172     
+ Misses      13006    12981      -25     
- Partials     7498     7499       +1
Files with missing lines Coverage Δ
src/node_sqlite.cc 81.08% <100.00%> (+0.02%) ⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97 geeksilva97 removed the blocked PRs that are blocked by other issues or PRs. label Aug 5, 2025
@geeksilva97 geeksilva97 changed the title sqlite: handle ?N bind params as positional sqlite: handle ?NNN bind params as positional Aug 5, 2025
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68422/

@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68432/

lluisemper
lluisemper reviewed Aug 6, 2025
View reviewed changes
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68445/

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68476/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@lluisemper lluisemper lluisemper left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[sqlite] Positional numbered question mark parameters are incorrectly bound as named parameters
4 participants
@geeksilva97 @nodejs-github-bot @himself65 @lluisemper