Do not reset globals when set as returnvalues

kkoopa · kkoopa · commit 91b4df4b483e · 2016-06-14T16:30:15.000+03:00
diff --git a/nan_callbacks_12_inl.h b/nan_callbacks_12_inl.h
@@ -38,7 +38,6 @@ class ReturnValue {
     value_.Set(handle);
 #else
     value_.Set(*reinterpret_cast<const v8::Persistent<S>*>(&handle));
-    const_cast<Global<S> &>(handle).Reset();
 #endif
   }
 
diff --git a/nan_callbacks_pre_12_inl.h b/nan_callbacks_pre_12_inl.h
@@ -40,7 +40,6 @@ class ReturnValue {
     TYPE_CHECK(T, S);
     value_->Dispose();
     *value_ = v8::Persistent<T>::New(handle.persistent);
-    const_cast<Global<S> &>(handle).Reset();
   }
 
   // Fast primitive setters

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,6 @@ class ReturnValue {`
`38`	`38`	`value_.Set(handle);`
`39`	`39`	`#else`
`40`	`40`	`value_.Set(reinterpret_cast<const v8::Persistent<S>>(&handle));`
`41`		`- const_cast<Global<S> &>(handle).Reset();`
`42`	`41`	`#endif`
`43`	`42`	`}`
`44`	`43`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,6 @@ class ReturnValue {`
`40`	`40`	`TYPE_CHECK(T, S);`
`41`	`41`	`value_->Dispose();`
`42`	`42`	`*value_ = v8::Persistent<T>::New(handle.persistent);`
`43`		`- const_cast<Global<S> &>(handle).Reset();`
`44`	`43`	`}`
`45`	`44`
`46`	`45`	`// Fast primitive setters`