Skip to content

Do not hardcode Release as the build type and expose Boost_INCLUDE_DIR #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Do not hardcode Release as the build type and expose Boost_INCLUDE_DIR #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
478fa42
CMakeLists.txt: let developer choose build type
Feb 10, 2017
103c3d6
src/CMakeLists.txt: expose Boost include dir
Feb 10, 2017
5ac5b31
README.md: add information about build types
Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ option(WITH_BENCHMARK "enable building benchmark executable" OFF)

set(CMAKE_INCLUDE_CURRENT_DIR ON)
set(CMAKE_INCLUDE_CURRENT_DIR_IN_INTERFACE ON)
set(CMAKE_BUILD_TYPE Release)

set(mstch_VERSION 1.0.1)

Expand Down
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,11 @@ from the root of the source tree:
$ make install
```

The install command may require root privileges. This will also install CMake
You can specify the
[build type](https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html) (Release, Debug...)
by adding -DCMAKE\_BUILD\_TYPE=BuildType to the `cmake` command.

The install command may require root privileges. This will also install CMake
config files, so you can use use `find_package` in your CMakeLists.txt:

```cmake
Expand Down
2 changes: 2 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ add_library(mstch STATIC ${SRC})

set_property(TARGET mstch PROPERTY VERSION ${mstch_VERSION})

target_include_directories(mstch PUBLIC ${Boost_INCLUDE_DIR})

install(
TARGETS mstch EXPORT mstchTargets
LIBRARY DESTINATION lib
Expand Down