Implement low-risk maintainability improvements to quote_script.gs

[devin-ai-integration]

Enhance Maintainability: Extract Functions and Implement Comprehensive Coefficient Logic

Summary

This PR implements the Single Responsibility Principle by extracting complex logic into dedicated, testable functions in quote_script.gs. The main improvements include:

1. Function Extraction: Added missing definitions for calculateCoefficientFromFundingSource_ and adjustFinalAnalysisTableCount_ functions that were being called but not defined (causing runtime errors)

2. Enhanced Coefficient Logic: Implemented comprehensive coefficient calculation rules with proper priority order:

   • Priority 1: G2 (試験種別) = "医師主導治験" → 1.5
   • Priority 2: AQ2 (調整事務局設置) = "あり" → 1.5
   • Priority 3: AN2 (原資) = "営利企業原資（製薬企業等）" → 1.5
   • Default: All other cases → 1.0

3. Comprehensive Test Coverage: Updated test_funding_source_logic.gs with 7 test scenarios covering all coefficient calculation rules and edge cases

4. Previous Maintainability Improvements: Includes trial period processing extraction, ConfigCache implementation, and constants consolidation

Review & Testing Checklist for Human

🔴 High Priority (Critical Business Logic)

• Verify coefficient calculation priority order matches actual business requirements exactly - test with real Quotation Request data containing different combinations of G2/AQ2/AN2 values
• Test main quote generation workflow (quote_script_main()) end-to-end to ensure no regressions and that coefficients are applied correctly to pricing calculations
• Validate final analysis table count adjustment works correctly for 医師主導治験 with table counts < 50 (should adjust to 50) vs other trial types (should remain unchanged)

🟡 Medium Priority (Integration & Edge Cases)

• Execute comprehensive test suite in Google Apps Script: run testFundingSourceLogic() and verify all 7 scenarios pass with expected coefficients
• Test with edge case data including empty/null values in G2/AQ2/AN2 fields to ensure graceful handling

Recommended Test Plan

1. Run testFundingSourceLogic() in Google Apps Script console and verify all tests pass
2. Test quote_script_main() with sample Quotation Request data containing different coefficient scenarios
3. Verify trial comments are generated correctly for final analysis table adjustments
4. Check that extracted functions integrate properly with SetSheetItemValues class usage

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TB
    QR["Quotation Request<br/>Sheet (AN2, AQ2, G2)"] --> GSMain["quote_script.gs<br/>quote_script_main()"]
    
    GSMain --> CalcCoeff["calculateCoefficientFrom<br/>FundingSource_()"]:::major-edit
    GSMain --> AdjustTable["adjustFinalAnalysis<br/>TableCount_()"]:::major-edit
    GSMain --> ProcessTrial["processAndWriteTrialPeriod_()"]:::minor-edit
    
    
    CalcCoeff --> QSC["QuoteScriptConstants"]:::context
    AdjustTable --> QSC
    
    TestFunding["test_funding_source_logic.gs"]:::major-edit --> CalcCoeff
    TestFunding --> MockData["Mock Quotation<br/>Request Data"]:::context
    
    ConfigCache["ConfigCache"]:::context --> CalcCoeff
    ConfigCache --> AdjustTable
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit  
        L3["Context/No Edit"]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF

Loading

Notes

• Session Details: Requested by @MarikoOhtsuka in session https://app.devin.ai/sessions/678899042bad4d14a55cfda6064d2611
• Critical Fix: This PR resolves runtime errors where functions were being called but not defined
• Business Logic Risk: The coefficient calculation involves complex priority-based rules that require careful validation against actual business requirements
• Testing Limitation: Google Apps Script environment limits automated testing - manual verification in the actual environment is essential
• Backward Compatibility: All existing function signatures and behaviors are preserved; this is purely additive functionality

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring

[devin-ai-integration]

Closing due to inactivity for more than 7 days. Configure here.