Disable GCC False array-bounds Warning
#4704
Closed
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #4701 should fix the CI issue. I'll ping you once it is merged to rebase this branch. |
Signed-off-by: Yehuda Bernat <[email protected]>
Signed-off-by: Yehuda Bernat <[email protected]>
|
Has this been reported to GCC as a bug? It seems like this is something that could pop up anywhere, and if we try to fix it everywhere it appears, we're going to be sprinkling these pragmas all over the code. |
2 tasks
|
I agree with @gregmarr that this should be fixed by GCC and not suppressed here by the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
JSON_DIAGNOSTICSis set to 1, GCC might (depending on optimization level and the exact code) give anarray-boundswarning about thebasic_json::basic_json(CompatibleType&&)constructor, saying thatbasic_json::set_parents()might access a larger object than the storage allocated byto_json. That is not true, as the storage is only accessed according to the value type set inm_data.m_typeby the constructing function, but GCC seems to not understand it.This PR simply adds preprocessor directives around the call to
set_parentsto ignore the warning.fixes #4657