Skip to content

Fix IP Address value in cert metadata #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Fix IP Address value in cert metadata #1187

merged 1 commit into from
Jul 31, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jul 28, 2025

Proposed changes

Fixed IP Addresses value in Cert Metadata
\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xff\xc0\xa8\x00\x01 -> 192.168.0.1

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jul 28, 2025
@aphralG aphralG requested a review from a team as a code owner July 28, 2025 13:17
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Jul 28, 2025
@aphralG aphralG added v3.x Issues and Pull Requests related to the major version v3 bug Something isn't working and removed bug Something isn't working chore Pull requests for routine tasks labels Jul 28, 2025
@aphralG aphralG merged commit 9d6131a into main Jul 31, 2025
58 of 59 checks passed
@aphralG aphralG deleted the fix-ip-address-value branch July 31, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@sean-breen sean-breen sean-breen approved these changes

@john-david3 john-david3 john-david3 approved these changes

Assignees

@aphralG aphralG

Labels
bug Something isn't working v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aphralG @dhurley @sean-breen @john-david3