Merge branch 'nextcloud:master' into master

Author: brainrom

.drone.yml

@@ -1,151 +1,3 @@
----
-kind: pipeline
-name: drone desktop client
-
-steps:
-- name: cmake
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - cmake /drone/src -G Ninja -DCMAKE_PREFIX_PATH=/opt/qt -DCMAKE_C_COMPILER=gcc-11 -DCMAKE_CXX_COMPILER=g++-11 -DCMAKE_BUILD_TYPE=Debug -DQT_MAJOR_VERSION=6 -DQUICK_COMPILER=ON -DBUILD_UPDATER=ON -DBUILD_TESTING=1 -DCMAKE_CXX_FLAGS=-Werror -DOPENSSL_ROOT_DIR=/usr/local/lib64 -DADD_E2E_TESTS=ON
-
-- name: compile
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - ninja
-
-- name: test
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - ../src/admin/test/wait_for_server.sh "server"
-    - useradd -m -s /bin/bash test
-    - chown -R test:test .
-    - su -c 'xvfb-run ctest --output-on-failure' test
-
-services:
-  - name: server
-    image: ghcr.io/nextcloud/continuous-integration-shallow-server:latest # also change in updateScreenshots.sh
-    environment:
-      EVAL: true
-      SERVER_VERSION: 'stable30'
-    commands:
-      - BRANCH="$SERVER_VERSION" /usr/local/bin/initnc.sh
-      - echo 127.0.0.1 server >> /etc/hosts
-      - apt-get update && apt-get install -y composer
-      - su www-data -c "OC_PASS=user1 php /var/www/html/occ user:add --password-from-env --display-name='User One' user1"
-      - su www-data -c "OC_PASS=user2 php /var/www/html/occ user:add --password-from-env --display-name='User Two' user2"
-      - su www-data -c "OC_PASS=user3 php /var/www/html/occ user:add --password-from-env --display-name='User Three' user3"
-      - su www-data -c "php /var/www/html/occ user:setting user2 files quota 1G"
-      - su www-data -c "php /var/www/html/occ group:add users"
-      - su www-data -c "php /var/www/html/occ group:adduser users user1"
-      - su www-data -c "php /var/www/html/occ group:adduser users user2"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/activity.git /var/www/html/apps/activity/"
-      - su www-data -c "php /var/www/html/occ app:enable activity"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/text.git /var/www/html/apps/text/"
-      - su www-data -c "php /var/www/html/occ app:enable text"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/end_to_end_encryption.git /var/www/html/apps/end_to_end_encryption/"
-      - su www-data -c "php /var/www/html/occ app:enable end_to_end_encryption"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/photos.git /var/www/html/apps/photos/"
-      - su www-data -c "cd /var/www/html/apps/photos; composer install"
-      - su www-data -c "php /var/www/html/occ app:enable -f photos"
-      - /usr/local/bin/run.sh
-
-volumes:
-- name: build
-  temp: {}
-
-trigger:
-  branch:
-    - master
-    - stable-*
-  event:
-    - pull_request
-    - push
-
----
-kind: pipeline
-name: qt-5.15-clang
-
-steps:
-- name: cmake
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - cmake /drone/src -G Ninja -DCMAKE_PREFIX_PATH=/opt/qt -DCMAKE_C_COMPILER=clang-14 -DCMAKE_CXX_COMPILER=clang++-14 -DCMAKE_BUILD_TYPE=Debug -DQT_MAJOR_VERSION=6 -DQUICK_COMPILER=ON -DBUILD_UPDATER=ON -DBUILD_TESTING=1 -DCMAKE_CXX_FLAGS=-Werror -DOPENSSL_ROOT_DIR=/usr/local/lib64 -DADD_E2E_TESTS=ON
-- name: compile
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - ninja
-- name: test
-  image: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
-  volumes:
-    - name: build
-      path: /drone/build
-  commands:
-    - cd /drone/build
-    - ../src/admin/test/wait_for_server.sh "server"
-    - useradd -m -s /bin/bash test
-    - chown -R test:test .
-    - su -c 'xvfb-run ctest --output-on-failure' test
-
-services:
-  - name: server
-    image: ghcr.io/nextcloud/continuous-integration-shallow-server:latest # also change in updateScreenshots.sh
-    environment:
-      EVAL: true
-      SERVER_VERSION: 'stable30'
-    commands:
-      - BRANCH="$SERVER_VERSION" /usr/local/bin/initnc.sh
-      - echo 127.0.0.1 server >> /etc/hosts
-      - apt-get update && apt-get install -y composer
-      - su www-data -c "OC_PASS=user1 php /var/www/html/occ user:add --password-from-env --display-name='User One' user1"
-      - su www-data -c "OC_PASS=user2 php /var/www/html/occ user:add --password-from-env --display-name='User Two' user2"
-      - su www-data -c "OC_PASS=user3 php /var/www/html/occ user:add --password-from-env --display-name='User Three' user3"
-      - su www-data -c "php /var/www/html/occ user:setting user2 files quota 1G"
-      - su www-data -c "php /var/www/html/occ group:add users"
-      - su www-data -c "php /var/www/html/occ group:adduser users user1"
-      - su www-data -c "php /var/www/html/occ group:adduser users user2"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/activity.git /var/www/html/apps/activity/"
-      - su www-data -c "php /var/www/html/occ app:enable activity"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/text.git /var/www/html/apps/text/"
-      - su www-data -c "php /var/www/html/occ app:enable text"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/end_to_end_encryption.git /var/www/html/apps/end_to_end_encryption/"
-      - su www-data -c "php /var/www/html/occ app:enable end_to_end_encryption"
-      - su www-data -c "git clone -b $SERVER_VERSION https://github.com/nextcloud/photos.git /var/www/html/apps/photos/"
-      - su www-data -c "cd /var/www/html/apps/photos; composer install"
-      - su www-data -c "php /var/www/html/occ app:enable -f photos"
-      - /usr/local/bin/run.sh
-
-volumes:
-- name: build
-  temp: {}
-
-trigger:
-  branch:
-    - master
-    - stable-*
-  event:
-    - pull_request
-    - push
-
 ---
 kind: pipeline
 name: Debian
@@ -168,5 +20,5 @@ trigger:
     - push
 ---
 kind: signature
-hmac: 4296d3beb6775fd1589c30b86412298de4f67e9791843c7bb484fc6d5bb01e4e
+hmac: e8978756454c02822b9b6b1b05013594fc5a6db04ac18537ef696fbf49700f7e
 ...

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @camilasan @claucambra @mgallien @nilsding

.github/workflows/check-translations.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      -   uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v3
-      -   name: Check German
-          run: |
-            [[ $(grep "Benötigt keine Übersetzung" translations/client_de.ts -c) -gt 0 ]] && exit 1 || exit 0
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - name: Check German
+        run: |
+          [[ $(grep "Benötigt keine Übersetzung" translations/client_de.ts -c) -gt 0 ]] && exit 1 || exit 0

.github/workflows/clang-format.yml

@@ -6,8 +6,8 @@ jobs:
   build:
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v4
-    - uses: cpp-linter/cpp-linter-action@v2.13.4
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+    - uses: cpp-linter/cpp-linter-action@8ae6cfaea8cc035c6155b5fe79d7991a9bf638af # v2.14.0
       id: linter
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/clang-tidy-review.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       with:
           fetch-depth: 2
     - name: Prepare compile_commands.json
@@ -24,7 +24,7 @@ jobs:
         /usr/bin/git config --global --add safe.directory "$GITHUB_WORKSPACE"
         /usr/bin/git diff -U0 HEAD^ | clang-tidy-diff-15.py -checks='-*,modernize-use-auto,modernize-use-using,modernize-use-nodiscard,modernize-use-nullptr,modernize-use-override,cppcoreguidelines-pro-type-static-cast-downcast' -p1 -path build -export-fixes clang-tidy-result/fixes.yml
     - name: Run clang-tidy-pr-comments action
-      uses: platisd/[email protected] # >1.4.3 switches to composite method w/ a forced python version and breaks things: https://github.com/actions/setup-python/issues/871
+      uses: platisd/clang-tidy-pr-comments@a8811fa17cd6bd02c52a3791b44f9840777e396a # v1.6.1 # >1.4.3 switches to composite method w/ a forced python version and breaks things: https://github.com/actions/setup-python/issues/871
       with:
         # The GitHub token (or a personal access token)
         github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/linux-appimage.yml

@@ -6,9 +6,9 @@ jobs:
   build:
     name: Linux Appimage Package
     runs-on: ubuntu-latest
-    container: ghcr.io/nextcloud/continuous-integration-client-appimage-qt6:client-appimage-el8-6.8.1-2
+    container: ghcr.io/nextcloud/continuous-integration-client-appimage-qt6:client-appimage-el8-6.8.2-1
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 1
 
@@ -21,15 +21,15 @@ jobs:
 
       - name: Upload AppImage artifact
         id: upload-appimage
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
         with:
           name: nextcloud-appimage-pr-${{ github.event.number }}
           path: ${{ steps.build-appimage.outputs.APPIMAGE_NAME }}
           overwrite: true
           compression-level: 0 # squashfs is already compressed
 
       - name: Comment AppImage
-        uses: actions/github-script@v7
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
         with:
           script: |
             const comment_identifier_string = "<!-- automated comment for an appimage build -->";

.github/workflows/linux-clang-compile-tests.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 1
       - name: Configure and compile

.github/workflows/linux-gcc-compile-tests.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     container: ghcr.io/nextcloud/continuous-integration-client-qt6:client-6.8.1-2
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 1
       - name: Configure and compile

.github/workflows/macos-build-and-test.yml

@@ -19,7 +19,7 @@ jobs:
       CRAFT_MASTER_CONFIG: ${{ github.workspace }}/craftmaster.ini
       CRAFT_BLUEPRINT_OPTIONS: ${{ matrix.craft_options }}
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           fetch-depth: 1
 
@@ -30,13 +30,13 @@ jobs:
         run: sudo xcode-select -s /Applications/Xcode_15.3.app/Contents/Developer
 
       - name: Restore cache
-        uses: actions/cache@v4
+        uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
         with:
           path: ~/cache
           key: macos-latest-${{ env.CRAFT_TARGET }}
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@8d9ed9ac5c53483de85588cdf95a591a75ab9f55 # v5.5.0
         with:
           python-version: 3.12
 

.github/workflows/needsinfo.yml

@@ -7,7 +7,7 @@ jobs:
     stale:
         runs-on: ubuntu-latest
         steps:
-            -   uses: actions/stale@v9
+            -   uses: actions/stale@5bef64f19d7facfb25b37b414482c7164d639639 # v9.1.0
                 with:
                     operations-per-run: 1500
                     days-before-stale: 28