fix(vfs/windows): update folder type when populated

after having populated the entries in a on-demand folder, update its
type in database to ensure updated state

only virtual folders have the on-demand feature enabled and that should
happen only once as we always fully populated a folder

Signed-off-by: Matthieu Gallien <[email protected]>

Author: mgallien

src/libsync/vfs/cfapi/cfapiwrapper.cpp

@@ -592,6 +592,20 @@ void CALLBACK cfApiFetchPlaceHolders(const CF_CALLBACK_INFO *callbackInfo, const
     qCInfo(lcCfApiWrapper()) << "ls prop finished" << path << serverPath;
 
     sendTransferInfo(newEntries);
+
+    auto newPlaceholdersResult = 0;
+    const auto invokeFinalizeResult = QMetaObject::invokeMethod(vfs,
+                                                                [&newPlaceholdersResult, vfs, &newEntries, &serverPath] { return vfs->finalizeNewPlaceholders(newEntries, serverPath); },
+                                                                Qt::BlockingQueuedConnection,
+                                                                &newPlaceholdersResult);
+    if (!invokeFinalizeResult) {
+        qCritical(lcCfApiWrapper) << "Failed to finalize hydration job for" << path << requestId;
+        sendTransferError();
+    }
+
+    if (!newPlaceholdersResult) {
+        sendTransferError();
+    }
 }
 
 void CALLBACK cfApiNotifyFileCloseCompletion(const CF_CALLBACK_INFO *callbackInfo, const CF_CALLBACK_PARAMETERS * /*callbackParameters*/)

src/libsync/vfs/cfapi/vfs_cfapi.cpp

@@ -529,6 +529,26 @@ int VfsCfApi::finalizeHydrationJob(const QString &requestId)
     return HydrationJob::Status::Error;
 }
 
+int VfsCfApi::finalizeNewPlaceholders(const QList<PlaceholderCreateInfo> &newEntries,
+                                      const QString &pathString)
+{
+    const auto &journal = params().journal;
+
+    auto folderRecord = SyncJournalFileRecord{};
+    const auto fetchRecordDbResult = journal->getFileRecord(pathString, &folderRecord);
+    if (!fetchRecordDbResult || !folderRecord.isValid()) {
+        return 0;
+    }
+
+    folderRecord._type = ItemTypeDirectory;
+    const auto updateRecordDbResult = journal->setFileRecord(folderRecord);
+    if (!updateRecordDbResult) {
+        return 0;
+    }
+
+    return 1;
+}
+
 VfsCfApi::HydratationAndPinStates VfsCfApi::computeRecursiveHydrationAndPinStates(const QString &folderPath, const Optional<PinState> &basePinState)
 {
     Q_ASSERT(!folderPath.endsWith('/'));

src/libsync/vfs/cfapi/vfs_cfapi.h

@@ -56,6 +56,9 @@ class VfsCfApi : public Vfs
 
     int finalizeHydrationJob(const QString &requestId);
 
+    int finalizeNewPlaceholders(const QList<OCC::PlaceholderCreateInfo> &newEntries,
+                                const QString &pathString);
+
 public slots:
     void requestHydration(const QString &requestId, const QString &path);
     void fileStatusChanged(const QString &systemFileName, OCC::SyncFileStatus fileStatus) override;