resoulved pep8 issues

Signed-off-by: Shiva Shankar Vaddepally <[email protected]>

Author: shivashankar-vaddepally

plugins/module_utils/common.py

@@ -20,6 +20,7 @@
 from .logger import log
 from .nitro_resource_map import NITRO_RESOURCE_MAP
 
+
 @trace
 def get_netscaler_version(client):
     is_exist, response = get_resource(client, "nsversion")
@@ -105,7 +106,7 @@ def get_resource(client, resource_name, resource_id=None, resource_module_params
         # for zero bindings and some resources, the response_body will be {'errorcode': 0, 'message': 'Done', 'severity': 'NONE'}
         if resource_name in NESTED_POST_DATA_RESOURCES:
             if "routerDynamicRouting" in response_body:
-                 response_body = response_body["routerDynamicRouting"]
+                response_body = response_body["routerDynamicRouting"]
         if resource_name not in response_body:
             if resource_name == "sslcipher":
                 resource_primary_key = NITRO_RESOURCE_MAP[resource_name]["primary_key"]
@@ -114,7 +115,7 @@ def get_resource(client, resource_name, resource_id=None, resource_module_params
                 ]
 
             return False, []
-        
+
         # `update-only` resources return a dict instead of a list.
         return_response = response_body[resource_name]
         # FIXME: NITRO-BUG: for some resources like `policypatset_pattern_binding`, NITRO returns keys with uppercase. eg: `String` for `string`.
@@ -194,6 +195,7 @@ def is_resource_exists(client, resource_name, resource_module_params):
     )
     return is_exists
 
+
 @trace
 def _check_create_resource_params(resource_name, resource_module_params, action=None):
     post_data = {}
@@ -226,26 +228,26 @@ def _check_create_resource_params(resource_name, resource_module_params, action=
     else:
         # TODO: Should we allow non-add keys for the resource? OR should we error out if any non-add key is passed?
         if resource_name in NESTED_POST_DATA_RESOURCES:
-                post_data = {"routerDynamicRouting": {resource_name: {}}}
-                resource_add_keys = NITRO_RESOURCE_MAP[resource_name]["add_payload_keys"]
-                
-                for key in resource_module_params.keys():
-                    if key in resource_add_keys:
-                        keylist = key.split(".")
-                        current_dict = post_data["routerDynamicRouting"][resource_name]
-                        for i, k in enumerate(keylist):
-                            if i == len(keylist) - 1:
-                                current_dict[k] = resource_module_params[key]
-                            else:
-                                if k not in current_dict:
-                                    current_dict[k] = {}
-                                current_dict = current_dict[k]
-                    else:
-                        log(
-                            "WARNING: Key `{}` is not allowed for the resource `{}` for CREATE operation. Skipping the key for the operation".format(
-                                key, resource_name
-                            )
+            post_data = {"routerDynamicRouting": {resource_name: {}}}
+            resource_add_keys = NITRO_RESOURCE_MAP[resource_name]["add_payload_keys"]
+
+            for key in resource_module_params.keys():
+                if key in resource_add_keys:
+                    keylist = key.split(".")
+                    current_dict = post_data["routerDynamicRouting"][resource_name]
+                    for i, k in enumerate(keylist):
+                        if i == len(keylist) - 1:
+                            current_dict[k] = resource_module_params[key]
+                        else:
+                            if k not in current_dict:
+                                current_dict[k] = {}
+                            current_dict = current_dict[k]
+                else:
+                    log(
+                        "WARNING: Key `{}` is not allowed for the resource `{}` for CREATE operation. Skipping the key for the operation".format(
+                            key, resource_name
                         )
+                    )
         else:
             for key in resource_module_params.keys():
                 if not action:
@@ -310,7 +312,7 @@ def create_resource(client, resource_name, resource_module_params, action=None):
     # For nested post data resources, post_data is already properly structured
     if resource_name not in NESTED_POST_DATA_RESOURCES:
         post_data = {resource_name: post_data}
-    
+
     status_code, response_body = client.post(
         post_data=post_data,
         resource=resource_name,

plugins/module_utils/module_executor.py

@@ -38,7 +38,6 @@
     HTTP_RESOURCE_ALREADY_EXISTS,
     NETSCALER_COMMON_ARGUMENTS,
     NITRO_ATTRIBUTES_ALIASES,
-    NESTED_POST_DATA_RESOURCES,
     GETALL_ONLY_RESOURCES,
 )
 from .decorators import trace