make fix_capitalization enabled by create_filename_symlinks

The restriction on requiring them to both be set true ... that was a little too onerous. Annoying if you change your global config to set create_filename_symlinks true and then try to go back to play previously installed mods.

Instead, just have create_filename_symlinks imply fix_capitalization. Seems highly unlikely you'd ever not want that behavior anyway.

Author: neogeographica

scripts/quakelaunch

@@ -41,19 +41,6 @@ function basic_validation {
   fi
 }
 
-# Function to check consistency in other conf properties, after any gamedir-
-# specific conf has been sourced.
-function more_validation {
-  if [[ $create_filename_symlinks == "true" ]]
-  then
-    if [[ "$fix_capitalization" != "true" ]]
-    then
-      message "create_filename_symlinks can only be enabled when fix_capitalization is also enabled"
-      exit 1
-    fi
-  fi
-}
-
 # Take care of the simplest arguments cases:
 
 # Forbid more than one arg.
@@ -578,7 +565,6 @@ then
     source "$gamedir"/quakelaunch.conf
   fi
   basic_validation
-  more_validation
   # If this directory is not under basedir or (if relevant) userdata_home, we
   # can't deal with it.
   if [[ "$gamedirparent" != "$basedir" ]]
@@ -625,7 +611,6 @@ then
     source "$conf"
   fi
   basic_validation
-  more_validation
   # Everything has been sourced. For certain overrides, note that we should
   # NOT try to calculate values for these vars below.
   if [[ $has_conf == "true" || $has_superconf == "true" ]]
@@ -679,8 +664,9 @@ then
       fi
     fi
   fi
-  # Take care of any obvious capitalization gotchas.
-  if [[ $fix_capitalization == "true" ]]
+  # Take care of any obvious capitalization gotchas. Note that setting
+  # create_filename_symlinks true implies forcing this true.
+  if [[ $fix_capitalization == "true" || $create_filename_symlinks == "true" ]]
   then
     if [[ -d "$basedir"/"$mod" ]]
     then
@@ -1045,7 +1031,6 @@ then
     basegame_error=""
     source "$conf"
     basic_validation
-    more_validation
   fi
   # If we just created this config, clean it up a bit by removing examples
   # and then initialize the preview_readme_and_config, fix_capitalization,

scripts/quakelaunch.conf

@@ -61,7 +61,7 @@ fix_capitalization=true
 # common mistakes occur. This should be a harmless thing to enable, but it
 # will create a lot of symlink spam so it's false by default.
 # Again this should not by needed by FTE but could help with other engines.
-# NOTE: you can only set this true when fix_capitalization is also true.
+# NOTE: Setting this to true will also force fix_capitalization to true.
 create_filename_symlinks=false
 
 # Whether Python module expak is installed, with "pip install expak". This