fix/observations-msg auto-commit

Author: pablorsk

src/Objects/InvoiceObject.php

@@ -50,7 +50,7 @@ class InvoiceObject extends FiscalDocumentDto
     /** @var int */
     public $cotizacionMoneda = 1;
     /** @var ?int */
-    public $condicionIVAReceptorId = null;
+    public $condicionIVAReceptorId;
     /** @var string */
     public $fechaServicioDesde;
     /** @var string */

src/Objects/Invoices/ConceptEnum.php

@@ -1,9 +1,17 @@
 <?php
+/**
+ * Copyright (C) 1997-2020 Reyesoft <[email protected]>.
+ *
+ * This file is part of php-afip-ws. php-afip-ws can not be copied and/or
+ * distributed without the express permission of Reyesoft
+ */
+
+declare(strict_types=1);
 
 namespace Multinexo\Objects\Invoices;
 
 /**
- * https://www.arca.gob.ar/ws/documentacion/manuales/manual-desarrollador-ARCA-COMPG-v4-0.pdf
+ * https://www.arca.gob.ar/ws/documentacion/manuales/manual-desarrollador-ARCA-COMPG-v4-0.pdf.
  */
 class ConceptEnum
 {

src/WSFE/Wsfe.php

@@ -71,16 +71,19 @@ private function parseResult(stdClass $response): InvoiceResultObject
         $result->cae = $response->CAE;
         $result->cae_expiration_date = $response->CAEFchVto;
         if (isset($response->Observaciones)) {
-            Log::debug('OBSERVATIONS: '. print_r($response->Observaciones->Obs, true) );
+            Log::debug('OBSERVATIONS: ' . print_r($response->Observaciones->Obs, true));
         }
         if (!empty($response->Observaciones->Obs)) {
             $messages = is_array($response->Observaciones->Obs)
                 ? $response->Observaciones->Obs
-            :  [$response->Observaciones->Obs];
-            $result->observation =array_map(
-                function ($obs) { return  $obs->Msg . ' (' . $obs->Code . ')'; },
+            : [$response->Observaciones->Obs];
+            $result->observation = implode(
+                array_map(
+                function ($obs) {
+                    return $obs->Msg . ' (' . $obs->Code . ').';
+                },
                 $messages
-            );
+            ), PHP_EOL);
         }
 
         return $result;