[Request] Replace SystemTime dependency to avoid runtime panic on WASM targets

[und3fined]

Same in title, The team can support wasm?

time::SystemTime not support in wasm, but chrono support it

[mplanchard]

Thanks for the suggestion! I'll take a look at this as soon as I get a chance. In the meantime, I'd have no issue accepting an MR

[mplanchard]

As far as I can tell SytemTime is supported in WASM. I have pushed some updates and am now testing WASM builds in CI against the wasm32-unknown-unknown and wasm32-wasi targets.

Please check e2d994a or later and see if it works for you

[erenaspire7]

Hi @mplanchard. It doesn't work for me. However, prisma has a wasm-compatible fix at prisma/prisma#17102 (comment)

[mplanchard]

@erenaspire7 doesn't work in what way? The wasm build works fine in CI for those targets.

[erenaspire7]

@mplanchard . So my use-case was inter-oping the package with typescript using wasm. It failed due to not having an equivalent for SystemTime within rust from the standard library

Prisma addressed this by using a web_time dependency

[mplanchard]

Oh, is it this runtime issue? rust-lang/rust#48564

Didn't realize the stdlib had stuff that would compile for a target but unequivocally panic at runtime

[erenaspire7]

Yeah, that's the issue. Thanks!

[mplanchard]

Great. I've got a wasm test now that shows the issue. I'll update to a different time dependency and get that pushed. Thanks for the lead!

[jkomyno]

Hey @mplanchard, hopefully I can push a PR within the next 7 days.
I am the author of the fix in Prisma mentioned by @erenaspire7 above

[mplanchard]

Hey @mplanchard, hopefully I can push a PR within the next 7 days.
I am the author of the fix in Prisma mentioned by @erenaspire7 above

Thanks! I may have it done by then, depends on work stuff. The master branch should work now, just working on getting the github actions tests cleaned up

[mplanchard]

Completed and released for CUID2 as cuid2-v0.1.4: https://github.com/mplanchard/cuid-rust/releases/tag/cuid2-v0.1.4

Still need to do v1, should get that done sometime this week

[mplanchard]

Fix released in a new cuid1 crate: https://crates.io/crates/cuid1

I'll be updating the main cuid crate to use one or both of cuid1 and/or cuid2 here in the near future. In the meantime, you can use whichever individual one you need.