Governed Gas Pool User Journeys

[l-monninger]

Summary

I am opening this discussion to cover Governed Gas Pool user journeys, particularly as inform e2e tests. Once agreed upon, these user journeys will be placed in issues.

The original testnet user journeys were provided in the e2e test sketch here: https://github.com/movementlabsxyz/movement/pull/957/files#diff-5af859a157b190153ae86e9a868f5f5ef02ab79743130de89b1da03dafc255ed

Note: the terms fund, asset, token, fee, and deposit refer to either aptos_framework::coin or aptos_framework::fa tokens.

1. A transaction sender WILL have their gas fees deposited into the Governed Gas Pool at the address of the resource account.
   • No additional gas fee deposits will be made.
2. A transaction sender CAN deposit non-native token into the governed_gas_pool.
3. A governance proposer under testnet feature flags can access fund from the governed_gas_pool module by calling aptos_governance::get_signer_testnet_only to acquire the aptos_framework signer and then calling governed_gas_pool::fund with said signer.
   • Proposals on testnet which do not acquire the aptos_framework signer will fail.
   • Non-governance or non aptos_framework signer attempts to use the Governed Gas Pool will fail.
4. The beneficiary of testnet governed_gas_pool::fund WILL receive their funds without any fees.
5. A governance proposer under mainnet features flags can likewise acquire the necessary signing privileges for governed_gas_pool::fund.
6. The governing body can vote the Governed Gas Pool version of the aptos_framework in following a version not using the Governed Gas Pool. Immediately following the epoch transition accompanying this vote, the gas fees are collected in the Governed Gas Pool.

[l-monninger]

Writing these e2e tests will necessarily involved a fair amount of wielding the aptos_core::governance module in general--for which we have not independently produced programmatic examples.

@0xmovses, this is where I think you and I can help @Icarus131 can get started on Monday. For example, item 6 above can be written without the governed_gas_pool.spec.move being completed. Likewise checking gas fees match expectations involves a little bit of fiddling with precalculating the gas algebra that doesn't rely on the governed_gas_pool being complete.

[0xmovses]

Yes I see, those tasks can be done in parallel. Ok I'll sync with @Icarus131 on this asap.

[0xmovses]

Happy to issue these up.