Merge pull request #43 from moovfinancial/fe-2041

FE-2041 Fix failing tests

Author: morganwalkup

bun.lock

@@ -28,7 +28,7 @@ describe("Accounts", () => {
       test("should fail if the account type is not supported", async () => {
         await expect(() =>
           createAccount({
-            accountType: "not-a-valid-account-type" as AccountType,
+            accountType: "not-a-valid-account-type" as "business" | "individual",
           }),
         ).toThrowError();
       });
@@ -102,7 +102,7 @@ describe("Accounts", () => {
       const legalBusinessName = chance.company();
       const { result } = await moov.accounts.update({
         accountID: account.accountID,
-        createAccountUpdate: { profile: { business: { legalBusinessName } } },
+        patchAccount: { profile: { business: { legalBusinessName } } },
       });
       expect(result).toBeDefined();
       expect(result.accountID).toEqual(account.accountID);

test/tests/accounts.test.ts

@@ -102,9 +102,7 @@ describe("Bank Accounts", () => {
                 accountID,
                 bankAccountID: bankAccount.bankAccountID!,
               }),
-          ).toThrowError(
-            expect.objectContaining({ error: "unacceptable bank account status verified for verification" }),
-          );
+          ).toThrowError(/found existing active verification/i);
         });
         test("should be able to get the bank account verification status", async () => {
           const { result } = await moov.bankAccounts.initiateVerification({
@@ -151,11 +149,7 @@ describe("Bank Accounts", () => {
                 accountID,
                 bankAccountID: bankAccount.bankAccountID!,
               }),
-          ).toThrowError(
-            expect.objectContaining({
-              error: "unexpected account status: expected 'new' or 'verificationFailed', found 'verified'",
-            }),
-          );
+          ).toThrowError(/unexpected account status: expected 'new' or 'verificationFailed'/i);
         });
       });
     });

test/tests/bankAccounts.test.ts

@@ -27,7 +27,7 @@ describe("Capabilities", () => {
         moov.capabilities.list({
           accountID: "not-a-valid-account-id",
         }),
-      ).toThrowError("API error occurred: Status 403 Content-Type  Body ");
+      ).toThrowError(/API error occurred: Status 403/);
     });
   });
 
@@ -79,7 +79,7 @@ describe("Capabilities", () => {
           accountID: "not-a-valid-account-id",
           capabilityID: "transfers",
         }),
-      ).toThrowError("API error occurred: Status 403 Content-Type  Body ");
+      ).toThrowError(/API error occurred: Status 403/i);
     });
 
     test("getting a capability should fail if the capability does not exist", async () => {
@@ -113,7 +113,7 @@ describe("Capabilities", () => {
             capabilities: ["transfers"],
           },
         }),
-      ).toThrowError("API error occurred: Status 403 Content-Type  Body ");
+      ).toThrowError(/API error occurred: Status 403/i);
     });
 
     test("requesting capabilities should fail if the capability is invalid", async () => {

test/tests/capabilities.test.ts

@@ -90,7 +90,7 @@ describe("Cards", () => {
 
       test("Getting a card should fail when I pass incorrect params", async () => {
         expect(async () => await moov.cards.get({ accountID, cardID: "invalid-card-id" })).toThrowError(
-          "API error occurred: Status 404 Content-Type  Body",
+          /API error occurred: Status 404/,
         );
       });
 
@@ -109,7 +109,7 @@ describe("Cards", () => {
 
       test("listing should fail when I pass incorrect params", async () => {
         expect(async () => await moov.cards.list({ accountID: "invalid-account-id" })).toThrowError(
-          "API error occurred: Status 403 Content-Type  Body ",
+          /API error occurred: Status 403/,
         );
       });
     });
@@ -145,7 +145,7 @@ describe("Cards", () => {
                 },
               },
             }),
-        ).toThrowError('API error occurred: {"expiration":"year: the length must be exactly 2."}');
+        ).toThrowError(/API error occurred:.*\"expiration\":\"year: the length must be exactly 2.\"/i);
       });
     });
 
@@ -160,7 +160,7 @@ describe("Cards", () => {
 
       test("disabling should fail when I pass incorrect params", async () => {
         expect(async () => await moov.cards.disable({ accountID, cardID: "invalid-card-id" })).toThrowError(
-          "API error occurred: Status 404 Content-Type  Body",
+          /API error occurred: Status 404/i,
         );
       });
     });

test/tests/cards.test.ts

@@ -26,7 +26,7 @@ describe("PaymentMethods", () => {
     });
     test("listing should fail if accountID is not provided", async () => {
       expect(() => moov.paymentMethods.list({ accountID: "" })).toThrowError(
-        "API error occurred: Status 403 Content-Type  Body",
+        /API error occurred: Status 403/i,
       );
     });
   });
@@ -43,12 +43,12 @@ describe("PaymentMethods", () => {
     });
     test("getting should fail if accountID and paymentMethodID are not correct", async () => {
       expect(() => moov.paymentMethods.get({ accountID: "@#$@#$@$", paymentMethodID: "@#$@#$@#$@" })).toThrowError(
-        "API error occurred: Status 403 Content-Type  Body",
+        /API error occurred: Status 403/i,
       );
     });
     test("getting should fail if paymentMethodID is not provided", async () => {
       expect(() => moov.paymentMethods.get({ accountID: accountID, paymentMethodID: "" })).toThrowError(
-        "API error occurred: Status 403 Content-Type  Body",
+        /API error occurred: Status 403/i,
       );
     });
   });

test/tests/paymentMethods.test.ts

@@ -40,7 +40,7 @@ describe("Representative", () => {
       });
       test("listing representatives should fail if the account is not found", async () => {
         expect(() => moov.representatives.list({ accountID: "not-a-valid-account-id" })).toThrowError(
-          "API error occurred: Status 403 Content-Type  Body ",
+          /API error occurred: Status 403/i,
         );
       });
       test("getting a representative should fail if the account is not found", async () => {
@@ -49,7 +49,7 @@ describe("Representative", () => {
             accountID: "not-a-valid-account-id",
             representativeID: representative.representativeID,
           }),
-        ).toThrowError("API error occurred: Status 403 Content-Type  Body ");
+        ).toThrowError(/API error occurred: Status 403/i);
       });
     });
     describe("Updating a representative", () => {
@@ -76,7 +76,7 @@ describe("Representative", () => {
               email: "[email protected]",
             },
           }),
-        ).toThrowError("API error occurred: Status 403 Content-Type  Body ");
+        ).toThrowError(/API error occurred: Status 403/i);
       });
     });
   });

test/tests/representatives.test.ts

@@ -1,7 +1,7 @@
 import { beforeAll, beforeEach, describe, expect, test } from "bun:test";
 import { ids, moov } from "../setup";
 import {
-  crateAccountAndGetTransferOptions,
+  createAccountAndGetTransferOptions,
   createAccount,
   createAccountWithWallet,
   createBankAccount,
@@ -10,20 +10,20 @@ import {
   UUID_REGEX,
   waitFor,
 } from "../utils/utils";
-import type { CreateTransferOptions, PaymentMethod, TransferResponse } from "../../models/components";
+import type { CreateTransferOptions, PaymentMethod, Transfer, CreatedTransfer, AsyncTransfer } from "../../models/components";
 import { sleep } from "bun";
 import type { CreateTransferRequest } from "../../models/operations";
 
 let destinationAccountID: string;
 let sourcePaymentMethodID: string;
 let destinationPaymentMethodID: string;
-let transfer: TransferResponse;
+let transfer: Transfer | CreatedTransfer | AsyncTransfer;
 describe("Transfers", () => {
-  // Setup accounts and payment methods
 
   describe("Transfer Creation", () => {
     beforeAll(async () => {
-      const availablePaymentMethods = await crateAccountAndGetTransferOptions();
+      // Setup accounts and payment methods
+      const availablePaymentMethods = await createAccountAndGetTransferOptions();
       sourcePaymentMethodID = availablePaymentMethods.sourceOptions![0].paymentMethodID!;
       destinationPaymentMethodID = availablePaymentMethods.destinationOptions![0].paymentMethodID!;
     });
@@ -99,7 +99,7 @@ describe("Transfers", () => {
       };
 
       await expect(() => moov.transfers.create(transferRequest)).toThrowError(
-        'API error occurred: {"amount":"amount value must be greater than or equal to 0.01"}',
+        /API error occurred: {"amount":"amount value must be greater than or equal to 0.01"}/i,
       );
     });
   });

test/tests/transfers.test.ts

@@ -22,7 +22,7 @@ describe("Wallets", () => {
     });
     test("listing should fail if accountID is not provided", async () => {
       expect(() => moov.wallets.list({ accountID: "" })).toThrowError(
-        "API error occurred: Status 403 Content-Type  Body",
+        /API error occurred: Status 403/i
       );
     });
   });

test/tests/wallets.test.ts

@@ -217,7 +217,7 @@ export const createCard = async (accountID: string, card: DeepPartial<LinkCard>
   return { card: result, cardNumber: mergedCard.cardNumber };
 };
 
-export const crateAccountAndGetTransferOptions = async () => {
+export const createAccountAndGetTransferOptions = async () => {
   const doneCheck = (data: { result: PaymentMethod[] }) => data.result.length > 0;
 
   // Create destination account with card and bank account
@@ -239,7 +239,10 @@ export const crateAccountAndGetTransferOptions = async () => {
     destination: { accountID: destinationAccountID },
     amount: { currency: "USD", value: 1 },
   };
-  const { result: availablePaymentMethods } = await moov.transfers.generateOptions(generateOptionsRequest);
+  const { result: availablePaymentMethods } = await moov.transfers.generateOptions({
+    accountID: SOURCE_ACCOUNT_ID,
+    createTransferOptions: generateOptionsRequest,
+  });
   expect(availablePaymentMethods).toBeDefined();
   expect(availablePaymentMethods.sourceOptions).toBeArray();
   expect(availablePaymentMethods.sourceOptions!.length).toBeGreaterThan(0);