code changes per code review comments

Author: NathanQingyangXu

src/integrationTest/java/com/mongodb/hibernate/query/select/SortingSelectQueryIntegrationTests.java

@@ -36,6 +36,7 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.EnumSource;
+import org.junit.jupiter.params.provider.ValueSource;
 
 @DomainModel(annotatedClasses = Book.class)
 class SortingSelectQueryIntegrationTests extends AbstractSelectionQueryIntegrationTests {
@@ -164,8 +165,8 @@ void testSortFieldNotFieldPathExpressionNotSupported() {
                     "from Book ORDER BY length(title)",
                     Book.class,
                     FeatureNotSupportedException.class,
-                    "%s does not support sort key not of field path type",
-                    MONGO_DBMS_NAME);
+                    "TODO-HIBERNATE-%1$d https://jira.mongodb.org/browse/HIBERNATE-%1$d",
+                    79);
         }
 
         @ParameterizedTest
@@ -188,7 +189,8 @@ void testCaseInsensitiveSortSpecNotSupported() {
                 criteria.select(root);
                 criteria.orderBy(cb.sort(root.get("title"), SortDirection.ASCENDING, NullPrecedence.NONE, true));
                 assertThatThrownBy(() -> session.createSelectionQuery(criteria).getResultList())
-                        .isInstanceOf(FeatureNotSupportedException.class);
+                        .isInstanceOf(FeatureNotSupportedException.class)
+                        .hasMessage("TODO-HIBERNATE-%1$d https://jira.mongodb.org/browse/HIBERNATE-%1$d", 79);
             });
         }
     }

src/main/java/com/mongodb/hibernate/internal/translate/AbstractMqlTranslator.java

@@ -371,11 +371,8 @@ public void visitQuerySpec(QuerySpec querySpec) {
         var stages = new ArrayList<AstStage>(3);
 
         createMatchStage(querySpec).ifPresent(stages::add);
-
         createSortStage(querySpec).ifPresent(stages::add);
-
-        var projectStageSpecifications = acceptAndYield(querySpec.getSelectClause(), PROJECT_STAGE_SPECIFICATIONS);
-        stages.add(new AstProjectStage(projectStageSpecifications));
+        stages.add(createProjectStage(querySpec.getSelectClause()));
 
         astVisitorValueHolder.yield(COLLECTION_AGGREGATE, new AstAggregateCommand(collection, stages));
     }
@@ -402,6 +399,11 @@ private Optional<AstSortStage> createSortStage(QuerySpec querySpec) {
         return Optional.empty();
     }
 
+    private AstProjectStage createProjectStage(SelectClause selectClause) {
+        var projectStageSpecifications = acceptAndYield(selectClause, PROJECT_STAGE_SPECIFICATIONS);
+        return new AstProjectStage(projectStageSpecifications);
+    }
+
     @Override
     public void visitFromClause(FromClause fromClause) {
         if (fromClause.getRoots().size() != 1) {
@@ -549,7 +551,7 @@ public void visitSortSpecification(SortSpecification sortSpecification) {
                     format("%s does not support null precedence: NULLS %s", MONGO_DBMS_NAME, nullPrecedence));
         }
         if (sortSpecification.isIgnoreCase()) {
-            throw new FeatureNotSupportedException("Case-insensitive sorting not supported");
+            throw new FeatureNotSupportedException("TODO-HIBERNATE-79 https://jira.mongodb.org/browse/HIBERNATE-79");
         }
 
         var astSortOrder =
@@ -574,8 +576,7 @@ public void visitSortSpecification(SortSpecification sortSpecification) {
 
     private AstSortField createAstSortField(Expression sortExpression, AstSortOrder astSortOrder) {
         if (!isFieldPathExpression(sortExpression)) {
-            throw new FeatureNotSupportedException(
-                    format("%s does not support sort key not of field path type", MONGO_DBMS_NAME));
+            throw new FeatureNotSupportedException("TODO-HIBERNATE-79 https://jira.mongodb.org/browse/HIBERNATE-79");
         }
         var fieldPath = acceptAndYield(sortExpression, FIELD_PATH);
         return new AstSortField(fieldPath, astSortOrder);