Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Commit a98180f

Browse files
committed
:fix: Broken deploy command passing wrong task name
1 parent 391a8b1 commit a98180f

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# Changelog
22
All notable changes to this project made by Monade Team are documented in this file. For info refer to [email protected]
33

4+
## [0.2.1] - 2021-03-25
5+
### Fixed
6+
- Broken deploy command passing wrong task name
7+
48
## [0.2.0] - 2021-03-25
59
### Added
610
- Command run-task

lib/ecs_deploy_cli/runners/diff.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def run!
1313
EcsDeployCli.logger.info '---'
1414
EcsDeployCli.logger.info "Task: #{task_name}"
1515

16-
result = ecs_client.describe_task_definition(task_definition: "#{task_name}").to_h
16+
result = ecs_client.describe_task_definition(task_definition: task_name).to_h
1717

1818
current = result[:task_definition].except(:revision, :status, :registered_at, :registered_by, :requires_attributes, :task_definition_arn)
1919

lib/ecs_deploy_cli/runners/update_services.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def run!(service: nil, timeout: 500)
1515
ecs_client.update_service(
1616
cluster: config[:cluster],
1717
service: service_name,
18-
task_definition: "#{task_definition[:family]}:#{task_name}"
18+
task_definition: task_name
1919
)
2020
wait_for_deploy(service_name, task_name, timeout: timeout)
2121
EcsDeployCli.logger.info "Deployed service \"#{service_name}\"!"

spec/ecs_deploy_cli/runner_spec.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,11 @@
142142

143143
it '#update_services!' do
144144
expect(mock_ecs_client).to receive(:register_task_definition).at_least(:once).and_return({ task_definition: { family: 'some', revision: '1' } })
145-
expect(mock_ecs_client).to receive(:update_service)
145+
expect(mock_ecs_client).to receive(:update_service).with(
146+
cluster: 'yourproject-cluster',
147+
service: 'yourproject-service',
148+
task_definition: 'some:1'
149+
)
146150
expect(mock_ecs_client).to receive(:wait_until)
147151

148152
expect_any_instance_of(EcsDeployCli::Runners::Base).to receive(:ecs_client).at_least(:once).and_return(mock_ecs_client)

0 commit comments

Comments
 (0)