Skip to content

Commit 3cf89f4

Browse files
committed
modal opens even when options are undefined.
1 parent 110b6a3 commit 3cf89f4

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

addon/components/ember-filestack-picker/component.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export default Ember.Component.extend({
4949
openFilepicker: on('didInsertElement', function () {
5050
scheduleOnce('afterRender', this, function () {
5151
this.get('filestack.promise').then((filestack) => {
52-
let options = this.get('options');
52+
let options = this.get('options') || {};
5353
options['onClose'] = options['onClose'] || this.getCallClose();
5454
filestack.pick(options).then((data) => {
5555
this.send('handleSelection', data);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-filestack",
3-
"version": "0.0.4",
3+
"version": "0.0.5",
44
"description": "Ember Addon for https://filestack.com support",
55
"keywords": [
66
"ember-addon"

tests/integration/components/ember-filestack-picker/component-test.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,19 @@ test('it renders', function (assert) {
1919
});
2020
});
2121

22+
test('it renders with undefined options', function (assert) {
23+
this.set('options', undefined);
24+
25+
this.render(hbs`{{ember-filestack-picker options=options}}`);
26+
27+
return wait().then(function () {
28+
assert.equal(window.$('.fsp-picker').length, 1, 'pick modal is open');
29+
30+
// close any open pickers
31+
window.$('.fsp-picker__close-button').click();
32+
});
33+
});
34+
2235
test('it calls onClose', function (assert) {
2336
this.set('options', {fromSources: 'local_file_system'});
2437
this.set('onClose', () => {

0 commit comments

Comments
 (0)