Add request time and memory usage

Author: mlanin

config/api-debugger.php

@@ -13,5 +13,8 @@
 
         // Profile custom events.
         \Lanin\Laravel\ApiDebugger\Collections\ProfilingCollection::class,
+
+        // Memory usage.
+        \Lanin\Laravel\ApiDebugger\Collections\MemoryCollection::class,
     ],
 ];

phpunit.xml

@@ -8,7 +8,6 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
 >
     <testsuites>
         <testsuite name="Package Test Suite">

src/Collections/MemoryCollection.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Lanin\Laravel\ApiDebugger\Collections;
+
+use Lanin\Laravel\ApiDebugger\Collection;
+
+class MemoryCollection implements Collection
+{
+    /**
+     * Collection name.
+     *
+     * @return string
+     */
+    public function name()
+    {
+        return 'memory';
+    }
+
+    /**
+     * Returns resulting collection.
+     *
+     * @return array
+     */
+    public function items()
+    {
+        return [
+            'usage' => memory_get_usage(),
+            'peak' => memory_get_peak_usage(),
+        ];
+    }
+}

src/Collections/ProfilingCollection.php

@@ -9,6 +9,8 @@
 
 class ProfilingCollection implements Collection
 {
+    const REQUEST_TIMER = 'request-time';
+
     /**
      * @var Dispatcher
      */
@@ -61,17 +63,42 @@ public function items()
      */
     public function listen()
     {
+        if (defined('LARAVEL_START')) {
+            $this->start(static::REQUEST_TIMER, LARAVEL_START);
+        }
+
         $this->dispatcher->listen(StartProfiling::class, function (StartProfiling $event) {
-            $this->started[$event->name] = microtime(true);
+            $this->start($event->name);
         });
 
         $this->dispatcher->listen(StopProfiling::class, function (StopProfiling $event) {
-            if (array_key_exists($event->name, $this->started)) {
-                $this->timers[] = [
-                    'event' => $event->name,
-                    'time' => microtime(true) - $this->started[$event->name],
-                ];
-            }
+            $this->stop($event->name);
         });
     }
+
+    /**
+     * Start timer.
+     *
+     * @param string $name
+     * @param null $time
+     */
+    protected function start($name, $time = null)
+    {
+        $this->started[$name] = $time ?: microtime(true);
+    }
+
+    /**
+     * Stop timer.
+     *
+     * @param string $name
+     */
+    protected function stop($name)
+    {
+        if (array_key_exists($name, $this->started)) {
+            $this->timers[] = [
+                'event' => $name,
+                'time' => microtime(true) - $this->started[$name],
+            ];
+        }
+    }
 }

src/Debugger.php

@@ -6,6 +6,7 @@
 use Illuminate\Foundation\Http\Events\RequestHandled;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
+use Lanin\Laravel\ApiDebugger\Collections\ProfilingCollection;
 use Lanin\Laravel\ApiDebugger\Events\StopProfiling;
 use Lanin\Laravel\ApiDebugger\Events\StartProfiling;
 use Symfony\Component\HttpFoundation\Response;
@@ -65,7 +66,6 @@ public function dump()
      * Start profiling event.
      *
      * @param  string $name
-     * @return mixed
      */
     public function startProfiling($name)
     {
@@ -106,6 +106,8 @@ public function profileMe($name, \Closure $action)
      */
     protected function updateResponse(Request $request, Response $response)
     {
+        $this->stopProfiling(ProfilingCollection::REQUEST_TIMER);
+
         if ($this->needToUpdateResponse($response)) {
             $data = $response->getData(true) ?: [];
             $data[$this->responseKey] = $this->storage->getData();

src/Support/helpers.php

@@ -20,12 +20,11 @@ function lad()
      * Start profiling event.
      *
      * @param  string $name
-     * @param Closure|null $action
      * @return void
      */
-    function lad_pr_start($name, \Closure $action = null)
+    function lad_pr_start($name)
     {
-        app(Debugger::class)->startProfiling($name, $action);
+        app(Debugger::class)->startProfiling($name);
     }
 }
 

tests/DebuggerTest.php

@@ -7,6 +7,25 @@
 
 class DebuggerTest extends TestCase
 {
+    /** @test */
+    public function it_can_dump_memory_usage()
+    {
+        $this->app['router']->get('foo', function () {
+            return response()->json(['foo' => 'bar']);
+        });
+
+        $this->json('get', '/foo')
+            ->assertStatus(200)
+            ->assertJsonStructure([
+                'debug' => [
+                    'memory' => [
+                        'usage',
+                        'peak',
+                    ],
+                ],
+            ]);
+    }
+
     /** @test */
     public function it_can_dump_var_via_helper()
     {
@@ -21,7 +40,7 @@ public function it_can_dump_var_via_helper()
             ->assertJsonFragment([
                 'dump' => [
                     'baz',
-                ]
+                ],
             ]);
     }
 
@@ -39,7 +58,7 @@ public function it_can_dump_multiple_vars()
             ->assertJsonFragment([
                 'dump' => [
                     ['baz1', 'baz2'],
-                ]
+                ],
             ]);
     }
 
@@ -164,8 +183,8 @@ public function it_can_show_cache_events()
                             'keys',
                             'total',
                         ],
-                    ]
-                ]
+                    ],
+                ],
             ])
             ->assertJsonFragment([
                 'miss' => [
@@ -174,10 +193,10 @@ public function it_can_show_cache_events()
                             'tags' => ['foo'],
                             'key' => 'bar',
                         ],
-                        'bar'
+                        'bar',
                     ],
-                    'total' => 2
-                ]
+                    'total' => 2,
+                ],
             ]);
     }
 }