Skip to content

Update DEDP title #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annagav wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update DEDP title #5439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dashboard/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Constants for the grades app
"""

DEDP_PROGRAM_TITLE = "Data, Economics, and Development Policy"
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"
Copy link

@gemini-code-assist gemini-code-assist bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using the program title as a string to identify a specific program is fragile. If the title changes in the database again, this logic will break. It would be more robust to identify this program using a more stable identifier, like a database ID, a slug, or a dedicated boolean field on the Program model. Since this is a wider change, it could be addressed in a separate ticket, but it's worth noting for future maintainability. I've added a comment to highlight this.

Suggested change
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"
# This is used to identify the DEDP program by its title. This is fragile and may break if the program title is changed in the database.
DEDP_PROGRAM_TITLE = "Data, Economics, and Design of Policy"

Loading