Make DNs fully case insensitive

donatello · donatello · commit 9d46cf88886a · 2025-05-14T14:53:44.000-07:00
diff --git a/ldap/ldap.go b/ldap/ldap.go
@@ -395,11 +395,12 @@ func LookupDN(conn *ldap.Conn, dn string, attrs []string) (*DNSearchResult, erro
 }
 
 // NormalizeDN normalizes the DN. The ldap library here mainly lowercases the
-// attribute type names in the DN.
+// attribute type names in the DN. However, since MinIO is going to be
+// case-insenstive, we lowercase the whole string.
 func NormalizeDN(dn string) (string, error) {
 	parsedDN, err := ldap.ParseDN(dn)
 	if err != nil {
 		return "", fmt.Errorf("DN (%s) parse failure: %w", dn, err)
 	}
-	return parsedDN.String(), nil
+	return strings.ToLower(parsedDN.String()), nil
 }
diff --git a/policy/action.go b/policy/action.go
@@ -206,7 +206,7 @@ const (
 	// PutObjectFanOutAction - PutObject like API action but allows PostUpload() fan-out.
 	PutObjectFanOutAction = "s3:PutObjectFanOut"
 
-	// S3Express CreateSession action
+	// CreateSessionAction - S3Express action
 	CreateSessionAction = "s3express:CreateSession"
 
 	// AllActions - all API actions

Original file line number	Diff line number	Diff line change
`@@ -395,11 +395,12 @@ func LookupDN(conn ldap.Conn, dn string, attrs []string) (DNSearchResult, erro`
`395`	`395`	`}`
`396`	`396`
`397`	`397`	`// NormalizeDN normalizes the DN. The ldap library here mainly lowercases the`
`398`		`-// attribute type names in the DN.`
	`398`	`+// attribute type names in the DN. However, since MinIO is going to be`
	`399`	`+// case-insenstive, we lowercase the whole string.`
`399`	`400`	`func NormalizeDN(dn string) (string, error) {`
`400`	`401`	`parsedDN, err := ldap.ParseDN(dn)`
`401`	`402`	`if err != nil {`
`402`	`403`	`return "", fmt.Errorf("DN (%s) parse failure: %w", dn, err)`
`403`	`404`	`}`
`404`		`- return parsedDN.String(), nil`
	`405`	`+ return strings.ToLower(parsedDN.String()), nil`
`405`	`406`	`}`