fix invalid out of bounds access

milleniumbug · milleniumbug · commit cef98534cfc5 · 2017-02-05T21:58:52.000+01:00
diff --git a/include/seed11/seed11.hpp b/include/seed11/seed11.hpp
@@ -207,7 +207,7 @@ namespace seed11
 	RandomAccessIterator choice(RandomAccessIterator first, RandomAccessIterator last, URNG&& urng)
 	{
 		typedef typename std::iterator_traits<RandomAccessIterator>::difference_type df_t;
-		std::uniform_int_distribution<df_t> dist(0, std::max(static_cast<df_t>(0), std::distance(first, last-1)));
+		std::uniform_int_distribution<df_t> dist(0, std::max(static_cast<df_t>(0), std::distance(first, last)-1));
 		return first + dist(urng);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ namespace seed11`
`207`	`207`	`RandomAccessIterator choice(RandomAccessIterator first, RandomAccessIterator last, URNG&& urng)`
`208`	`208`	`{`
`209`	`209`	`typedef typename std::iterator_traits<RandomAccessIterator>::difference_type df_t;`
`210`		`- std::uniform_int_distribution<df_t> dist(0, std::max(static_cast<df_t>(0), std::distance(first, last-1)));`
	`210`	`+ std::uniform_int_distribution<df_t> dist(0, std::max(static_cast<df_t>(0), std::distance(first, last)-1));`
`211`	`211`	`return first + dist(urng);`
`212`	`212`	`}`
`213`	`213`