Use constant for click-target class

mikejacobson · mikejacobson · commit 0246b941f185 · 2018-01-29T17:57:58.000-08:00
Also bump version to 2.4.0
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "jquery-bootstrap-scrolling-tabs",
-  "version": "2.3.1",
+  "version": "2.4.0",
   "main": [
     "./dist/jquery.scrolling-tabs.js",
     "./dist/jquery.scrolling-tabs.css"
diff --git a/dist/jquery.scrolling-tabs.js b/dist/jquery.scrolling-tabs.js
@@ -302,6 +302,7 @@
     CSS_CLASSES: {
       BOOTSTRAP4: 'scrtabs-bootstrap4',
       RTL: 'scrtabs-rtl',
+      SCROLL_ARROW_CLICK_TARGET: 'scrtabs-click-target',
       SCROLL_ARROW_DISABLE: 'scrtabs-disable',
       SCROLL_ARROW_WITH_CLICK_TARGET: 'scrtabs-with-click-target'
     },
@@ -500,11 +501,11 @@
   
         // if we have custom arrow content, we might have a click target defined
         if (settings.leftArrowContent) {
-          $leftArrowClickTarget = $leftArrow.find('.scrtabs-click-target');
+          $leftArrowClickTarget = $leftArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);
         }
   
         if (settings.rightArrowContent) {
-          $rightArrowClickTarget = $rightArrow.find('.scrtabs-click-target');
+          $rightArrowClickTarget = $rightArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);
         }
   
         if ($leftArrowClickTarget && $leftArrowClickTarget.length) {
diff --git a/dist/jquery.scrolling-tabs.min.js b/dist/jquery.scrolling-tabs.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "jquery-bootstrap-scrolling-tabs",
-  "version": "2.3.1",
+  "version": "2.4.0",
   "description": "jQuery plugin for scrollable Bootstrap Tabs",
   "homepage": "https://github.com/mikejacobson/jquery-bootstrap-scrolling-tabs",
   "bugs": "https://github.com/mikejacobson/jquery-bootstrap-scrolling-tabs/issues",
diff --git a/src/js/constants.js b/src/js/constants.js
@@ -12,6 +12,7 @@ var CONSTANTS = {
   CSS_CLASSES: {
     BOOTSTRAP4: 'scrtabs-bootstrap4',
     RTL: 'scrtabs-rtl',
+    SCROLL_ARROW_CLICK_TARGET: 'scrtabs-click-target',
     SCROLL_ARROW_DISABLE: 'scrtabs-disable',
     SCROLL_ARROW_WITH_CLICK_TARGET: 'scrtabs-with-click-target'
   },
diff --git a/src/js/elementsHandler.js b/src/js/elementsHandler.js
@@ -142,11 +142,11 @@ function ElementsHandler(scrollingTabsControl) {
 
       // if we have custom arrow content, we might have a click target defined
       if (settings.leftArrowContent) {
-        $leftArrowClickTarget = $leftArrow.find('.scrtabs-click-target');
+        $leftArrowClickTarget = $leftArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);
       }
 
       if (settings.rightArrowContent) {
-        $rightArrowClickTarget = $rightArrow.find('.scrtabs-click-target');
+        $rightArrowClickTarget = $rightArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);
       }
 
       if ($leftArrowClickTarget && $leftArrowClickTarget.length) {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "jquery-bootstrap-scrolling-tabs",`
`3`		`- "version": "2.3.1",`
	`3`	`+ "version": "2.4.0",`
`4`	`4`	`"main": [`
`5`	`5`	`"./dist/jquery.scrolling-tabs.js",`
`6`	`6`	`"./dist/jquery.scrolling-tabs.css"`
Original file line number	Diff line number	Diff line change
`@@ -142,11 +142,11 @@ function ElementsHandler(scrollingTabsControl) {`
`142`	`142`
`143`	`143`	`// if we have custom arrow content, we might have a click target defined`
`144`	`144`	`if (settings.leftArrowContent) {`
`145`		`- $leftArrowClickTarget = $leftArrow.find('.scrtabs-click-target');`
	`145`	`+ $leftArrowClickTarget = $leftArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`if (settings.rightArrowContent) {`
`149`		`- $rightArrowClickTarget = $rightArrow.find('.scrtabs-click-target');`
	`149`	`+ $rightArrowClickTarget = $rightArrow.find('.' + CONSTANTS.CSS_CLASSES.SCROLL_ARROW_CLICK_TARGET);`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`if ($leftArrowClickTarget && $leftArrowClickTarget.length) {`